From d69111910b61ee2b03a48a6c8048691f6986bfce Mon Sep 17 00:00:00 2001 From: Nye Liu Date: Fri, 17 Aug 2018 20:31:21 -0700 Subject: [PATCH] Fix Bug 199967 - change WARN_ON(1) to IWL_ERR() The TX_STATUS_FAIL_DEST_PS case fills logs with full backtraces, which are pretty useless. Just do IWL_ERR() printk. Signed-off-by: Nye Liu --- drivers/net/wireless/intel/iwlwifi/mvm/tx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c index cf2591f2ac23..87044953e6b4 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c @@ -1407,8 +1407,10 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm *mvm, /* the FW should have stopped the queue and not * return this status */ - WARN_ON(1); info->flags |= IEEE80211_TX_STAT_TX_FILTERED; + IWL_ERR(mvm, "TX_STATUS_FAIL_DEST_PS: " + "tid %d, status %x, flags %x\n", tid, status, + info->flags); break; default: break; -- 2.18.0