Bug 9006 - incorrect method to turn off DPLL in intel framebuffer driver
Summary: incorrect method to turn off DPLL in intel framebuffer driver
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Console/Framebuffers (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Antonino Daplas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-11 00:40 UTC by William Pan
Modified: 2007-09-15 16:36 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.18.1
Subsystem:
Regression: ---
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description William Pan 2007-09-11 00:40:22 UTC 
in file intelfbhw.c, function intelfbhw_program_mode, the steps to 
turn off DPLL:
	tmp = INREG(dpll_reg);
	dpll_reg &= ~DPLL_VCO_ENABLE;
	OUTREG(dpll_reg, tmp);
guess it should be:
	tmp = INREG(dpll_reg);
	tmp &= ~DPLL_VCO_ENABLE;
	OUTREG(dpll_reg, tmp);
am I right?
Comment 1 Anonymous Emailer 2007-09-11 00:50:19 UTC 
Reply-To: akpm@linux-foundation.org

On Tue, 11 Sep 2007 00:40:22 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=9006
> 
>            Summary: incorrect method to turn off DPLL in intel framebuffer
>                     driver
>            Product: Platform Specific/Hardware
>            Version: 2.5
>      KernelVersion: 2.6.18.1
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: i386
>         AssignedTo: platform_i386@kernel-bugs.osdl.org
>         ReportedBy: william.pan@kontron.cn
> 
> 
> in file intelfbhw.c, function intelfbhw_program_mode, the steps to 
> turn off DPLL:
>         tmp = INREG(dpll_reg);
>         dpll_reg &= ~DPLL_VCO_ENABLE;
>         OUTREG(dpll_reg, tmp);
> guess it should be:
>         tmp = INREG(dpll_reg);
>         tmp &= ~DPLL_VCO_ENABLE;
>         OUTREG(dpll_reg, tmp);
> am I right?
> 

?
Comment 2 Antonino Daplas 2007-09-12 00:55:58 UTC 
I believe so. Have you tried the driver with the modified code?
Comment 3 William Pan 2007-09-12 02:10:03 UTC 
No.




william.pan
2007-09-12
Comment 4 Antonino Daplas 2007-09-15 16:36:33 UTC 
Submitted a patch for the -mm tree.  Thanks for the report.
Note You need to log in before you can comment on or make changes to this bug.