Bug 8146 - A bug or a bad comment? scc_net_rx is not called from scc_rxint
Summary: A bug or a bad comment? scc_net_rx is not called from scc_rxint
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Network (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Jeff Garzik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-07 20:13 UTC by Lin Tan
Modified: 2007-11-02 12:09 UTC (History)
0 users

See Also:
Kernel Version: 2.6.20.1
Subsystem:
Regression: ---
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lin Tan 2007-03-07 20:13:47 UTC 
1613 /* ----> receive frame, called from scc_rxint() <---- */
1614 
1615 static void scc_net_rx(struct scc_channel *scc, struct sk_buff *skb)

But it is not called from scc_rxint().

the violating call chains are : 
1. t_txdelay -> scc_txint -> scc_tx_done -> scc_notify
2. scc_isr -> scc_isr_dispatch -> scc_txint -> scc_tx_done -> scc_notify

A bug or a wrong comment?
Comment 1 Dave Jones 2007-06-06 00:07:23 UTC 
patch posted to netdev.
Comment 2 Lin Tan 2007-06-09 21:24:07 UTC 
Could you add the patch or the link of the patch to the report, so that we have
a record in the Bugzilla? Thanks.
Comment 3 Lin Tan 2007-11-02 12:09:56 UTC 
The bad comment is fixed according to 
http://www.spinics.net/lists/netdev/msg32976.html
Note You need to log in before you can comment on or make changes to this bug.