Bug 8053 - net/ieee80211/ieee80211_crypt_tkip.c spams kernel message buffer
Summary: net/ieee80211/ieee80211_crypt_tkip.c spams kernel message buffer
Status: CLOSED CODE_FIX
Alias: None
Product: Networking
Classification: Unclassified
Component: Wireless (show other bugs)
Hardware: i386 Linux
: P2 high
Assignee: John W. Linville
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-21 16:57 UTC by Andreas Steinmetz
Modified: 2007-04-24 07:19 UTC (History)
0 users

See Also:
Kernel Version: 2.6.20.1
Subsystem:
Regression: ---
Bisected commit-id:


Attachments

Description Andreas Steinmetz 2007-02-21 16:57:51 UTC
As sent to lkml and netdev on 2007/02/07 without any reply:

net/ieee80211/ieee80211_crypt_tkip.c outputs tons of these which didn't
happen with 2.6.18.2 (only one or two of these after enabling the
ipw2200 with the kill switch):

TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e560
printk: 19 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e574
printk: 19 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e588
printk: 18 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e59b
printk: 19 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e5af
printk: 19 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e5c3
printk: 19 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e5d7
printk: 19 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e5eb
printk: 19 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e5ff
printk: 16 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e612
printk: 17 messages suppressed.
TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
received TSC 00000002e626

Note that the AP in question is a LCS-WA5-40 running in WPA/WPA2 mixed mode and
that the client in uses:

proto=RSN
pairwise=CCMP
group=TKIP
Comment 1 Anonymous Emailer 2007-02-21 17:17:53 UTC
Reply-To: akpm@linux-foundation.org

On Wed, 21 Feb 2007 16:57:59 -0800
bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=8053
> 
>            Summary: net/ieee80211/ieee80211_crypt_tkip.c spams kernel
>                     message buffer
>     Kernel Version: 2.6.20.1
>             Status: NEW
>           Severity: high
>              Owner: networking_wireless@kernel-bugs.osdl.org
>          Submitter: ast@domdv.de
> 
> 
> As sent to lkml and netdev on 2007/02/07 without any reply:
> 
> net/ieee80211/ieee80211_crypt_tkip.c outputs tons of these which didn't
> happen with 2.6.18.2 (only one or two of these after enabling the
> ipw2200 with the kill switch):
> 
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e560
> printk: 19 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e574
> printk: 19 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e588
> printk: 18 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e59b
> printk: 19 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e5af
> printk: 19 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e5c3
> printk: 19 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e5d7
> printk: 19 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e5eb
> printk: 19 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e5ff
> printk: 16 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e612
> printk: 17 messages suppressed.
> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
> received TSC 00000002e626
> 
> Note that the AP in question is a LCS-WA5-40 running in WPA/WPA2 mixed mode and
> that the client in uses:
> 
> proto=RSN
> pairwise=CCMP
> group=TKIP
> 

How rude.  Can we please get that message killed in both 2.6.21 and
2.6.20.x?

Comment 2 Larry Finger 2007-02-24 18:55:49 UTC
Andrew Morton wrote:
> On Wed, 21 Feb 2007 16:57:59 -0800
> bugme-daemon@bugzilla.kernel.org wrote:
> 
>> http://bugzilla.kernel.org/show_bug.cgi?id=8053
>>
>>            Summary: net/ieee80211/ieee80211_crypt_tkip.c spams kernel
>>                     message buffer
>>     Kernel Version: 2.6.20.1
>>             Status: NEW
>>           Severity: high
>>              Owner: networking_wireless@kernel-bugs.osdl.org
>>          Submitter: ast@domdv.de
>>
>>
>> As sent to lkml and netdev on 2007/02/07 without any reply:
>>
>> net/ieee80211/ieee80211_crypt_tkip.c outputs tons of these which didn't
>> happen with 2.6.18.2 (only one or two of these after enabling the
>> ipw2200 with the kill switch):
>>
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e560
>> printk: 19 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e574
>> printk: 19 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e588
>> printk: 18 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e59b
>> printk: 19 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e5af
>> printk: 19 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e5c3
>> printk: 19 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e5d7
>> printk: 19 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e5eb
>> printk: 19 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e5ff
>> printk: 16 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e612
>> printk: 17 messages suppressed.
>> TKIP: replay detected: STA=00:0e:2e:94:84:c3 previous TSC 020000000000
>> received TSC 00000002e626
>>
>> Note that the AP in question is a LCS-WA5-40 running in WPA/WPA2 mixed mode and
>> that the client in uses:
>>
>> proto=RSN
>> pairwise=CCMP
>> group=TKIP
>>
> 
> How rude.  Can we please get that message killed in both 2.6.21 and
> 2.6.20.x?

With the previous TSC having that strange value (020000000000), there must be some sort of driver
and/or AP error. With the possible exception of the situation where the "previous" and "received"
TSC are the same indicating a retransmit, I feel such messages are of value and do not support
killing them.

Larry


Comment 3 Andreas Steinmetz 2007-02-25 04:55:29 UTC
I'm quite certain that this is not an AP error. I did boot back into 2.6.18.2
and got after deasserting the kill switch:

ipw2200: Failed to send SCAN_ABORT: Command timed out.
ipw2200: Failed to send CARD_DISABLE: Command timed out.
CCMP: replay detected: STA=00:0e:2e:94:84:c3 previous PN 000000000000 received
PN 000000000000

Then, after rebooting into 2.6.20.1 with the spamming message patched away (see
patch below) I got the following after deasserting the kill switch:

ipw2200: Failed to send SCAN_ABORT: Command timed out.
ipw2200: Failed to send CARD_DISABLE: Command timed out.
CCMP: replay detected: STA=00:0e:2e:94:84:c3 previous PN 000000000000 received
PN 000000000000

Rude spam message silencing patch:

--- linux-2.6.20.orig/net/ieee80211/ieee80211_crypt_tkip.c      2007-02-04 19:44
:54.000000000 +0100
+++ linux-2.6.20/net/ieee80211/ieee80211_crypt_tkip.c   2007-02-24 13:54:16.0000
00000 +0100
@@ -464,12 +464,14 @@
        pos += 8;

        if (tkip_replay_check(iv32, iv16, tkey->rx_iv32, tkey->rx_iv16)) {
+#if 0
                if (net_ratelimit()) {
                        printk(KERN_DEBUG "TKIP: replay detected: STA=" MAC_FMT
                               " previous TSC %08x%04x received TSC "
                               "%08x%04x\n", MAC_ARG(hdr->addr2),
                               tkey->rx_iv32, tkey->rx_iv16, iv32, iv16);
                }
+#endif
                tkey->dot11RSNAStatsTKIPReplays++;
                return -4;

Even as this may well be a driver problem couldn't there be some verbosity
option, even with the default being the current verbosity? With the current
spamming output rate you can't find any other messages in the ring buffer,
everything else is spammed away.
Comment 4 John W. Linville 2007-03-01 11:16:04 UTC
What if it were wrapped by IEEE80211_DEBUG instead?
Comment 5 Andreas Steinmetz 2007-03-01 11:48:24 UTC
Fine with me.
Comment 6 John W. Linville 2007-04-24 07:19:01 UTC
"[PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging conditional" 
will be available was merged on 9 April 2007 and should be available in 
2.6.22.

Note You need to log in before you can comment on or make changes to this bug.