Bug 6545 - pktcdvd driver's major number is not properly initialized
Summary: pktcdvd driver's major number is not properly initialized
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Jens Axboe
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-13 23:28 UTC by Jurij Smakov
Modified: 2006-05-14 02:27 UTC (History)
0 users

See Also:
Kernel Version: 2.6.16.12
Subsystem:
Regression: ---
Bisected commit-id:


Attachments

Description Jurij Smakov 2006-05-13 23:28:36 UTC
Distribution: Debian unstable
Problem Description: Even though pktcdvd driver is assigned a static major
device number (97 block, according to Documentation/devices.txt), driver module
fails to initialize it properly. As a result, the device number is getting
assigned dynamically, which is not what one might naively expect. 

Steps to reproduce:
# modprobe pktcdvd
# grep pktcdvd /proc/devices
253 pktcdvd

This value is in contradiction to the one mentioned in devices.txt. Thanks to
Vincent Fourmond for noticing.
Comment 1 Anonymous Emailer 2006-05-14 01:59:34 UTC
Reply-To: petero2@telia.com

On Sun, 14 May 2006, Andrew Morton wrote:

> Begin forwarded message:
>
> Date: Sat, 13 May 2006 23:29:38 -0700
> From: bugme-daemon@bugzilla.kernel.org
> To: bugme-new@lists.osdl.org
> Subject: [Bugme-new] [Bug 6545] New: pktcdvd driver's major number is
> not properly initialized
>
>
> http://bugzilla.kernel.org/show_bug.cgi?id=6545
>
>            Summary: pktcdvd driver's major number is not properly
>                     initialized
>     Kernel Version: 2.6.16.12
>             Status: NEW
>           Severity: normal
>              Owner: axboe@suse.de
>          Submitter: jurij@wooyd.org
>
>
> Distribution: Debian unstable
> Problem Description: Even though pktcdvd driver is assigned a static major
> device number (97 block, according to Documentation/devices.txt), driver module
> fails to initialize it properly. As a result, the device number is getting
> assigned dynamically, which is not what one might naively expect.
>
> Steps to reproduce:
> # modprobe pktcdvd
> # grep pktcdvd /proc/devices
> 253 pktcdvd
>
> This value is in contradiction to the one mentioned in devices.txt.
> Thanks to Vincent Fourmond for noticing.

Changing the driver to use dynamic device numbers was one of the many
changes that were made in order to have the driver accepted into the
mainline kernel. Therefore I would say that the entry in devices.txt is
obsolete. This patch removes it.

Signed-off-by: Peter Osterlund <petero2@telia.com>
---

 Documentation/devices.txt |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/Documentation/devices.txt b/Documentation/devices.txt
index 3c406ac..b369a8c 100644
--- a/Documentation/devices.txt
+++ b/Documentation/devices.txt
@@ -1721,11 +1721,6 @@ Your cooperation is appreciated.
 		These devices support the same API as the generic SCSI
 		devices.

- 97 block	Packet writing for CD/DVD devices
-		  0 = /dev/pktcdvd0	First packet-writing module
-		  1 = /dev/pktcdvd1	Second packet-writing module
-		    ...
-
  98 char	Control and Measurement Device (comedi)
 		  0 = /dev/comedi0	First comedi device
 		  1 = /dev/comedi1	Second comedi device




Note You need to log in before you can comment on or make changes to this bug.