Bug 6354 - NULL Pointer lapbether
Summary: NULL Pointer lapbether
Status: CLOSED CODE_FIX
Alias: None
Product: Networking
Classification: Unclassified
Component: Other (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Arnaldo Carvalho de Melo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-08 08:11 UTC by Pascal SCLAFER
Modified: 2006-04-23 16:21 UTC (History)
0 users

See Also:
Kernel Version: 2.6.14 2.6.15 2.6.16
Subsystem:
Regression: ---
Bisected commit-id:


Attachments

Description Pascal SCLAFER 2006-04-08 08:11:14 UTC
Problem Description:

Lapbether generate an oops, when I try to receive or sends packets over X25.

I think that the problem was introduced by this patch:
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=86e65da9c1fc6fb421b9f796b597b3eced6b55ab

The line skb->input_dev = skb->dev = dev; was removed from x25devices.h causing
all drivers using x25_type_trans() to crash, because skb->dev stay unintialized.

I think this line should have been replaced by skb->dev=dev;


PS: Sorry for my bad english

Note You need to log in before you can comment on or make changes to this bug.