Bug 6345 - Errors in headers, typedef's and function used outside __KERNEL__ scope
Summary: Errors in headers, typedef's and function used outside __KERNEL__ scope
Status: CLOSED CODE_FIX
Alias: None
Product: Other
Classification: Unclassified
Component: Other (show other bugs)
Hardware: i386 Linux
: P2 high
Assignee: Sam Ravnborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-07 04:33 UTC by Jerry Lundstr
Modified: 2006-08-21 00:34 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.16.1
Subsystem:
Regression: ---
Bisected commit-id:


Attachments
Patch for input.h (385 bytes, patch)
2006-04-07 04:34 UTC, Jerry Lundstr
Details | Diff
Patch for bitops.h (406 bytes, patch)
2006-04-07 04:34 UTC, Jerry Lundstr
Details | Diff
Patch for processor.h (430 bytes, patch)
2006-04-07 04:35 UTC, Jerry Lundstr
Details | Diff

Description Jerry Lundstr 2006-04-07 04:33:39 UTC
Most recent kernel where this bug did not occur: None
Distribution: Lunar Linux
Problem Description:

There are errors in the kernel headers. Typedef's and functions that are defined
inside the __KERNEL__ scope are used elsewhere outside the __KERNEL__ scope
which produce compilation errors when including the headers.
I found this in linux/input.h, linux/bitops.h and asm/processor.h .
Comment 1 Jerry Lundstr 2006-04-07 04:34:22 UTC
Created attachment 7798 [details]
Patch for input.h
Comment 2 Jerry Lundstr 2006-04-07 04:34:53 UTC
Created attachment 7799 [details]
Patch for bitops.h
Comment 3 Jerry Lundstr 2006-04-07 04:35:23 UTC
Created attachment 7800 [details]
Patch for processor.h
Comment 4 Jerry Lundstr 2006-04-07 04:37:18 UTC
linux/input.h was reported 2006-03-29
http://bugzilla.kernel.org/show_bug.cgi?id=6302 .

These patches are only temporary, from the looks of things there is surlly alot
more "misstakes" in the headers.
Comment 5 Sam Ravnborg 2006-08-03 14:08:12 UTC
David Woodhouse has initiated an effort to create user-space clean header.
See the headers* targets in recent kernel snapshot.

As part f this effort the below files will be (or are already cleaned up).

David - please let me know if  can close this bug.
/Sam
Comment 6 David Woodhouse 2006-08-03 16:32:45 UTC
input.h is fixed; bitops.h and processor.h are not visible to userspace. If the
reporter wants to file any more _specific_ bugs, please go ahead -- but I think
this bug can probably be closed.
Comment 7 Sam Ravnborg 2006-08-03 23:56:05 UTC
The issues reported are either already covered or not suitable for userspace.
So the ticket is closed.
/Sam
Comment 8 Jerry Lundstr 2006-08-21 00:34:09 UTC
Yes this can be kept closed, latest headers are fine (been on holliday so sorry
for the late answer).

The problem wasnt that things are not usable/visible within userspace, problem
was that the old headers exported kernel space items into userspace or visa
versa (ie missing ifdef __KERNEL__).

Note You need to log in before you can comment on or make changes to this bug.