Bug 6032 - linux 2.6.15.3 networking bug in r8169 device driver while having mac changed
Summary: linux 2.6.15.3 networking bug in r8169 device driver while having mac changed
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Network (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Francois Romieu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-08 15:41 UTC by Guy Jr. Wiltfang
Modified: 2007-07-19 14:08 UTC (History)
4 users (show)

See Also:
Kernel Version: 2.6.15.3
Subsystem:
Regression: ---
Bisected commit-id:


Attachments
Mac addr setting support (1.17 KB, patch)
2006-04-23 15:20 UTC, Francois Romieu
Details | Diff
Mac addr setting support - take #2 (1.33 KB, patch)
2006-04-23 15:39 UTC, Francois Romieu
Details | Diff
MAC address change support - take #3 (1.81 KB, patch)
2006-05-14 03:19 UTC, Francois Romieu
Details | Diff
MAC address change support - take #4 (2.03 KB, patch)
2006-05-31 15:34 UTC, Francois Romieu
Details | Diff

Description Guy Jr. Wiltfang 2006-02-08 15:41:09 UTC
Most recent kernel where this bug did not occur:

Distribution:
Debian 3.2 Etch GNU/Linux 2.6.15.3

Hardware Environment:
0000:00:00.0 Host bridge: Silicon Integrated Systems [SiS] 741/741GX/M741 Host
(rev 03)
0000:00:01.0 PCI bridge: Silicon Integrated Systems [SiS]: Unknown device 0003
0000:00:02.0 ISA bridge: Silicon Integrated Systems [SiS] SiS963 [MuTIOL Media
IO] (rev 25)
0000:00:02.1 SMBus: Silicon Integrated Systems [SiS]: Unknown device 0016
0000:00:02.5 IDE interface: Silicon Integrated Systems [SiS] 5513 [IDE]
0000:00:02.7 Multimedia audio controller: Silicon Integrated Systems [SiS] Sound
Controller (rev a0)
0000:00:03.0 USB Controller: Silicon Integrated Systems [SiS] USB 1.0 Controller
(rev 0f)
0000:00:03.1 USB Controller: Silicon Integrated Systems [SiS] USB 1.0 Controller
(rev 0f)
0000:00:03.2 USB Controller: Silicon Integrated Systems [SiS] USB 2.0 Controller
0000:00:04.0 Ethernet controller: Silicon Integrated Systems [SiS] SiS900 PCI
Fast Ethernet (rev 90)
0000:00:0a.0 PCI bridge: Digital Equipment Corporation DECchip 21152 (rev 01)
0000:01:00.0 VGA compatible controller: Silicon Integrated Systems [SiS]
661FX/M661FX/M661MX/741/M741/760/M760 PCI/AGP
0000:03:00.0 Ethernet controller: Digital Equipment Corporation DECchip 21142/43
(rev 30)
0000:03:04.0 Ethernet controller: Digital Equipment Corporation DECchip 21142/43
(rev 30)
0000:03:08.0 Ethernet controller: Digital Equipment Corporation DECchip 21142/43
(rev 30)
0000:03:0c.0 Ethernet controller: Digital Equipment Corporation DECchip 21142/43
(rev 30)

Software Environment:
Gnu C                  4.0.3
Gnu make               3.81beta4
binutils               2.16.91
util-linux             2.12p
mount                  2.12p
module-init-tools      3.2.2
e2fsprogs              1.39-WIP
reiserfsprogs          line
reiser4progs           line
Linux C Library        2.3.5
Dynamic linker (ldd)   2.3.5
Procps                 3.2.5
Net-tools              1.60
Console-tools          0.2.3
Sh-utils               5.2.1
udev                   081

Problem Description:
As soon as I fake me MAC address I am not able to either send nor receive
packages over this interface.

Steps to reproduce:
/etc/init.d/chmac
#!/bin/bash
#
# Set up random mac for eth0
#

case "$1" in
start)
    echo "Setting up random mac for eth0"
    ifconfig eth0 down
    macchanger -r eth0
    ;;
stop)
    echo "Setting up real mac for eth0"
    ifconfig eth0 down
    macchanger -m 00:11:5b:xx:xx:xx eth0
    ;;
*)
    echo "Usage: /etc/init.d/chmac {start|stop}"
    exit 1
    ;;
esac
Comment 1 Guy Jr. Wiltfang 2006-02-09 03:04:05 UTC
I am sorry, I put the wrong lspci output in the bug report. Foo me :-/

0000:00:00.0 Host bridge: Transmeta Corporation TM8000 Northbridge
0000:00:01.0 PCI bridge: Transmeta Corporation TM8000 AGP bridge
0000:00:02.0 PCI bridge: ALi Corporation M5249 HTT to PCI Bridge
0000:00:03.0 ISA bridge: ALi Corporation M1563 HyperTransport South Bridge (rev 20)
0000:00:03.1 Bridge: ALi Corporation M7101 Power Management Controller [PMU]
0000:00:04.0 Multimedia audio controller: ALi Corporation M5455 PCI AC-Link
Controller Audio Device (rev 10)
0000:00:04.1 Modem: ALi Corporation M5457 AC'97 Modem Controller (rev 10)
0000:00:0e.0 IDE interface: ALi Corporation M5229 IDE (rev c5)
0000:00:0f.0 USB Controller: ALi Corporation USB 1.1 Controller (rev 03)
0000:00:0f.1 USB Controller: ALi Corporation USB 1.1 Controller (rev 03)
0000:00:0f.3 USB Controller: ALi Corporation USB 2.0 Controller (rev 01)
0000:01:00.0 VGA compatible controller: Trident Microsystems XGI Volari XP5 (rev 02)
0000:02:09.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8169
Gigabit Ethernet (rev 10)
0000:02:0a.0 Network controller: RaLink Ralink RT2500 802.11 Cardbus Reference
Card (rev 01)
Comment 2 Francois Romieu 2006-04-23 15:20:11 UTC
Created attachment 7941 [details]
Mac addr setting support

Can you give the patch above a try ?

-- 
Ueimor
Comment 3 Francois Romieu 2006-04-23 15:39:46 UTC
Created attachment 7942 [details]
Mac addr setting support - take #2
Comment 4 Guy Jr. Wiltfang 2006-04-27 05:09:46 UTC
> ------- Additional Comments From romieu@fr.zoreil.com  2006-04-23 15:20
> -------
> Created an attachment (id=7941)
>  --> (http://bugzilla.kernel.org/attachment.cgi?id=7941&action=view)

Hello,

> Mac addr setting support
> 
> Can you give the patch above a try ?

Thanks very much. It seems to work for me.
 
> -- 
> Ueimor
> 
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
> 

Nice Greetings Guy Jr. Wiltfang 
Comment 5 Guy Jr. Wiltfang 2006-05-10 00:34:11 UTC
I tryed 2.6.17-rc3, but I still don't get the driver to work properly. It seemed
to work for 2.6.16.14 once. I rebooted 2.6.16.14 and then it didn't work again :-/
Comment 6 Francois Romieu 2006-05-10 04:15:25 UTC
Can you check that the patch was correctly applied each time ?

It is not in mainline yet.

-- 
Ueimor
Comment 7 Francois Romieu 2006-05-14 03:19:46 UTC
Created attachment 8114 [details]
MAC address change support - take #3
Comment 8 Francois Romieu 2006-05-14 03:41:03 UTC
A typo in the previous patch could explain that it seemed to work.

Can you give the current one a try ?

-- 
Ueimor
Comment 9 Francois Romieu 2006-05-31 15:34:36 UTC
Created attachment 8234 [details]
MAC address change support - take #4

I'll give this one a try on sparc64 to be sure but it
seems to work correctly on a test pc:
- MAC address can be set before or after ifconfig up ;
- the advertised MAC address matches.

Can you tell if it works correctly for you ?

-- 
Ueimor
Comment 10 Guy Jr. Wiltfang 2006-06-28 14:50:39 UTC
I have configured and compiled every kernel up to 2.6.17.1 (and all the -rc
patches) but I still don't get the same result.
Comment 11 Francois Romieu 2006-06-28 14:58:08 UTC
> I have configured and compiled every kernel up to 2.6.17.1 (and all the -rc
> patches) but I still don't get the same result.

Do you mean that you have applied patch#4 on top of each tried kernel and that
none of these allowed to change the mac address ?

-- 
Ueimor
Comment 12 Guy Jr. Wiltfang 2006-07-11 05:31:38 UTC
> ------- Additional Comments From romieu@fr.zoreil.com  2006-06-28 14:58
> -------
> > I have configured and compiled every kernel up to 2.6.17.1 (and all the -rc
> > patches) but I still don't get the same result.
> 
> Do you mean that you have applied patch#4 on top of each tried kernel and
> that
> none of these allowed to change the mac address ?

That is correct. Is there something else I can do for you to help solve the
problem?
 
Nice Greetings Guy Jr. Wiltfang 
-- 
The technology that is
Stronger, Better, Faster: Linux

Linux, a way of life !

NOTICE: Due to Presidential Executive Orders, the 
National Security Agency may have read this email 
without warning, warrant, or notice, and certainly 
without probable cause. They may do this without 
any judicial or legislative oversight. You have no 
recourse nor protection.
Comment 13 Guennadi Liakhovetski 2006-10-28 14:14:09 UTC
Looks like this patch got included into 2.6.19-rcX? It breaks the driver for me.
I don't need to change the mac, so, it just used to work before. It doesn't
anymore. The original bug-reporter also was unhappy about it, I think, so, how
did it get into mainline?
Comment 14 Francois Romieu 2006-10-29 02:54:29 UTC
bugme-daemon@bugzilla.kernel.org <bugme-daemon@bugzilla.kernel.org> :
[...]
> Looks like this patch got included into 2.6.19-rcX? It breaks the driver for me.
> I don't need to change the mac, so, it just used to work before. It doesn't
> anymore. The original bug-reporter also was unhappy about it, I think, so, how
> did it get into mainline ?

Short version: it works here, it worked elsewhere, it induced no regression
anywhere, it was included into -mm, users where Cc:ed, nobody reported any
remaining issue [*] [**].

The short version above summarizes a mixture of mail on netdev, linux-kernel,
private mailbox and bugzilla.

The mac address change has been included in the patches that I have published
as:
20060612-2.6.17-rc6-git-r8169-test.patch
20060911-2.6.18-rc6-r8169-test.patch
20060920-2.6.18-r8169-test.patch

The 8169 serie has been included in -mm since 2006/08.

It is still possible that I messed/missed something though.
That's why there are -rc too.

Satisfied ?

Can you:
- send a complete dmesg of the broken driver
- send an 'lspci -vvx'
- remove the call to __rtl8169_set_mac_addr() in rtl8169_hw_start()

I assume that you reverted the 'change MAC address" patch in 2.6.19-rc to
figure the culprit, right ?

[*]  Leenert did for ARM after 2.6.19-rc. His board is a bit special though.
[**] Beside link management issue on some 0x8168. Patch pending.

Comment 15 Guy Jr. Wiltfang 2007-03-25 08:36:23 UTC
> http://bugzilla.kernel.org/show_bug.cgi?id=6032
> 
> Do you mean that you have applied patch#4 on top of each tried kernel and that
> none of these allowed to change the mac address ?

I had tried it a while ago and it seemed to work now. Thanks you very much !

Nice Greetings Guy Jr. Wiltfang 
-- 
The technology that is
Stronger, Better, Faster: Linux

Linux, a way of life !

NOTICE: Due to Presidential Executive Orders, the 
National Security Agency may have read this email 
without warning, warrant, or notice, and certainly 
without probable cause. They may do this without 
any judicial or legislative oversight. You have no 
recourse nor protection.

Comment 16 Francois Romieu 2007-04-02 14:42:55 UTC
Due to the regression noticed by Guennadi, the original patch was reverted.
The latest test kit is available at:

http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.21-rc5/r8169-20070402

or:

http://www.fr.zoreil.com/people/francois/misc/20070402-2.6.21-rc5-r8169-test.patch

Could both of you give it a try ?

Thanks in advance.

-- 
Ueimor
Comment 17 Guy Jr. Wiltfang 2007-04-03 02:47:41 UTC
> ------- Additional Comments From romieu@fr.zoreil.com  2007-04-02 14:42
> -------
> Due to the regression noticed by Guennadi, the original patch was reverted.
> The latest test kit is available at:
>
> http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.21-rc5/r8169-20070402

Works great for me. Thanks for the improvment on the driver!

Nice day

Nice Greetings Guy Jr. Wiltfang 
-- 
The technology that is
Stronger, Better, Faster: Linux

Linux, a way of life !

NOTICE: Due to Presidential Executive Orders, the 
National Security Agency may have read this email 
without warning, warrant, or notice, and certainly 
without probable cause. They may do this without 
any judicial or legislative oversight. You have no 
recourse nor protection.
Comment 18 Natalie Protasevich 2007-07-18 17:22:33 UTC
It looks like the bug can be closed now.
Thanks.

Note You need to log in before you can comment on or make changes to this bug.