Bug 5351 - S3 resume: no video - Toshiba Satellite Pro 6000
Summary: S3 resume: no video - Toshiba Satellite Pro 6000
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Video(Other) (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Venkatesh Pallipadi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-02 16:40 UTC by David Leemans
Modified: 2006-08-09 20:57 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.14-rc2, rc3, final
Subsystem:
Regression: ---
Bisected commit-id:


Attachments
dmesg kernel 2.6.13.2 - video OK after resume (11.55 KB, text/plain)
2005-11-02 07:59 UTC, David Leemans
Details
dmesg kernel 2.6.14 - video not OK after resume (13.40 KB, text/plain)
2005-11-02 08:00 UTC, David Leemans
Details
output of lspci -v (3.88 KB, text/plain)
2005-11-02 08:02 UTC, David Leemans
Details
Drop vesafb_blank() (2.68 KB, patch)
2005-11-10 20:51 UTC, Antonino Daplas
Details | Diff

Description David Leemans 2005-10-02 16:40:51 UTC
Most recent kernel where this bug did not occur: 2.6.13.2
Distribution: Slackware 10.1
Hardware Environment: Toshiba Satellite Pro 6000 laptop
Software Environment: Xorg 6.8.2, XFCE 4.2, acpid 1.0.4
Problem Description: After resuming from S3 (suspended  while in X), the LCD
panel stays black . However, the laptop is up again, and I can SSH into it from
another machine.
I can get the panel working again, when I first direct video output to the CRT
output of the laptop, and then back to LCD (done by repeatedly hitting Fn+F5
buttons on the Toshiba, which directs output to either LCD, CRT or TV) 
None of this ever happened with older kernels.

Steps to reproduce: 
- boot with 2.6.14-rc2 or rc3
- suspend to S3 (done by closing lid)
- resume from S3 (done by opening lid)
- notice how laptop resumes but screen stays black
Comment 1 Len Brown 2005-10-06 21:22:49 UTC
So if you boot with 2.6.13.2 this failure goes away
and the LCD is restored properly after S3 resume?
Comment 2 David Leemans 2005-10-07 07:14:55 UTC
Yes, indeed. Fact is, I never experienced this video resume problem with any
kernel < 2.6.14. So far, my Toshiba worked perfectly well using ACPI. 
I was actually a little surpised to see a new kernel (albeit an rc) come up with
a problem.
  
Comment 3 Venkatesh Pallipadi 2005-10-19 18:47:39 UTC
Can you please post comlete dmesg with both working and non-working kernels?

Comment 4 David Leemans 2005-11-02 07:59:08 UTC
Created attachment 6449 [details]
dmesg kernel 2.6.13.2 - video OK after resume
Comment 5 David Leemans 2005-11-02 08:00:28 UTC
Created attachment 6450 [details]
dmesg kernel 2.6.14 - video not OK after resume

laptop was suspended for a few hours
Comment 6 David Leemans 2005-11-02 08:02:10 UTC
Created attachment 6451 [details]
output of lspci -v
Comment 7 David Leemans 2005-11-02 08:08:16 UTC
I added the dmesg ouput you asked for. Honestly, I don't see any difference.

I also would like to note that de video resume problem occurs only when
suspended  in X11. When suspended in console mode (actually vesa fb), video is
fine when resuming.
In fact, when the laptop resumes (suspended in X11), I see the console messages
(back to C! etc) briefly before the lcd panel goes black again.

If you need more info, don't hesitate to ask. 
Comment 8 David Leemans 2005-11-08 11:11:13 UTC
Bug is kind of "fixed" by resorting to vga=normal instead of 1024x768 vesa fb
mode. When the laptop resumes now, everything is OK.  
Did something change in the vesa fb code of 2.6.14 ?
Comment 9 Antonino Daplas 2005-11-08 15:29:04 UTC
vesafb is not really hooked up to the power management system of the kernel.  In
2.6.14, there are minor changes in the blanking code of vesafb.

Can you try copying drivers/video/vesafb.c from the working kernel to the
non-working kernel?
Comment 10 David Leemans 2005-11-10 11:01:01 UTC
> Can you try copying drivers/video/vesafb.c from the working kernel to the
> non-working kernel?

Did so, and yes, it solves the problem ;) 
Apparently, the changes made to the vesafb driver of 2.6.14 don't mix well with
resuming from memory. Maybe we should assign the bug now to the veasfb maintainer ?
Comment 11 Antonino Daplas 2005-11-10 20:51:10 UTC
Created attachment 6532 [details]
Drop vesafb_blank()

Okay.  The recently added vesafb_blank() method is giving problems with laptop
users. It works with CRT displays, but they don't need this as much as laptop
users.

Try this patch.  It drops the vesafb_blank() hook from vesafb.
Comment 12 David Leemans 2005-11-13 13:05:45 UTC
> Try this patch.  It drops the vesafb_blank() hook from vesafb.

Patch seems 100% OK. I have tested this for 2 days now, and my laptop
suspends/resumes without any problem each time. I think you can close this bug ;) 
Thx alot for a job well done.
Comment 13 Venkatesh Pallipadi 2005-12-14 15:14:18 UTC
I am not sure who is driving this fix into the base.

Antonino: Are you driving this? Can I assume that this will be fixed in
upstreamkernel and close this bug?

Thanks.
Comment 14 Antonino Daplas 2005-12-14 16:22:40 UTC
The fix is in akpm's tree.  It will eventually go to mainline but I don't know
when. So you can mark this as resolved at least.
Comment 15 Venkatesh Pallipadi 2005-12-14 16:33:01 UTC
In mm tree 2.6.15-rc*-mm*
Marking the bug resolved.
Comment 16 David Leemans 2006-01-07 06:24:02 UTC
The fix didn't make into 2.6.15 (final). I still had to apply the patch myself.
Will it make it into 2.6.16 ?
Comment 17 Antonino Daplas 2006-01-07 16:52:46 UTC
Yes, it did not get in to 2.6.15, it was a bit too late.  But it will in 2.6.16
Comment 18 David Leemans 2006-01-08 04:34:36 UTC
OK, thx again.
Comment 19 Len Brown 2006-08-09 20:57:42 UTC
the patch in comment #11 went upstream on Jan 10, 2006.
closed.

Note You need to log in before you can comment on or make changes to this bug.