Bug 283 - Compile failure of drivers/char/isicom.c
Summary: Compile failure of drivers/char/isicom.c
Status: CLOSED PATCH_ALREADY_AVAILABLE
Alias: None
Product: Drivers
Classification: Unclassified
Component: Serial (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Adrian Bunk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-01-17 16:59 UTC by Jayce Dowell
Modified: 2004-07-10 17:09 UTC (History)
0 users

See Also:
Kernel Version: 2.5.59
Subsystem:
Regression: ---
Bisected commit-id:

Attachments
2.5.59 .config file (38.53 KB, text/plain)
2003-01-17 17:00 UTC, Jayce Dowell 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jayce Dowell 2003-01-17 16:59:46 UTC 
Distribution: Mandrake 9.0
Hardware Environment: Athlon-XP
Software Environment: gcc-3.2
Problem Description: Compile failure of drivers/char/isicome.c
     
     gcc -Wp,-MD,drivers/char/.isicom.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-default
-fomit-frame-pointer -nostdinc -iwithprefix include -DMODULE  
-DKBUILD_BASENAME=isicom -DKBUILD_MODNAME=isicom   -c -o drivers/char/isicom.o
drivers/char/isicom.c
drivers/char/isicom.c:87: warning: type defaults to `int' in declaration of
`DECLARE_TASK_QUEUE'
drivers/char/isicom.c:87: warning: parameter names (without types) in function
declaration
drivers/char/isicom.c:87: warning: data definition has no type or storage class
drivers/char/isicom.c: In function `schedule_bh':
drivers/char/isicom.c:363: warning: implicit declaration of function `queue_task'
drivers/char/isicom.c:363: `tq_isicom' undeclared (first use in this function)
drivers/char/isicom.c:363: (Each undeclared identifier is reported only once
drivers/char/isicom.c:363: for each function it appears in.)
drivers/char/isicom.c:364: warning: implicit declaration of function `mark_bh'
drivers/char/isicom.c:364: `ISICOM_BH' undeclared (first use in this function)
drivers/char/isicom.c: In function `do_isicom_bh':
drivers/char/isicom.c:492: warning: implicit declaration of function
`run_task_queue'
drivers/char/isicom.c:492: `tq_isicom' undeclared (first use in this function)
drivers/char/isicom.c: In function `isicom_interrupt':
drivers/char/isicom.c:592: warning: `_MOD_INC_USE_COUNT' is deprecated (declared
at include/linux/module.h:429)
drivers/char/isicom.c:593: warning: implicit declaration of function `schedule_task'
drivers/char/isicom.c:594: warning: `__MOD_DEC_USE_COUNT' is deprecated
(declared at include/linux/module.h:404)
drivers/char/isicom.c:661: structure has no member named `tqueue'
drivers/char/isicom.c:661: `tq_timer' undeclared (first use in this function)
drivers/char/isicom.c:699: structure has no member named `tqueue'
drivers/char/isicom.c: In function `isicom_setup_board':
drivers/char/isicom.c:848: warning: `_MOD_INC_USE_COUNT' is deprecated (declared
at include/linux/module.h:429)
drivers/char/isicom.c: In function `isicom_shutdown_board':
drivers/char/isicom.c:1106: warning: `__MOD_DEC_USE_COUNT' is deprecated
(declared at include/linux/module.h:404)
drivers/char/isicom.c: In function `do_isicom_hangup':
drivers/char/isicom.c:1646: warning: `__MOD_DEC_USE_COUNT' is deprecated
(declared at include/linux/module.h:404)
drivers/char/isicom.c: In function `isicom_init':
drivers/char/isicom.c:1890: warning: implicit declaration of function `init_bh'
drivers/char/isicom.c:1890: `ISICOM_BH' undeclared (first use in this function)
drivers/char/isicom.c:1906: structure has no member named `routine'
drivers/char/isicom.c:1908: structure has no member named `routine'
drivers/char/isicom.c: In function `cleanup_module':
drivers/char/isicom.c:2041: warning: implicit declaration of function `remove_bh'
drivers/char/isicom.c:2041: `ISICOM_BH' undeclared (first use in this function)
make[2]: *** [drivers/char/isicom.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

Steps to reproduce: make dep && make bzImage && make modules
                    .config file attached
Comment 1 Jayce Dowell 2003-01-17 17:00:28 UTC 
Created attachment 73 [details]
2.5.59 .config file
Comment 2 Thomas Molina 2003-02-21 21:50:36 UTC 
This problem continues to exist in 2.5.62
Comment 3 HJH 2003-07-08 09:24:41 UTC 
still does not compile in 2.5.74
outputs the following:

  CC [M]  drivers/char/isicom.o
drivers/char/isicom.c:83: warning: type defaults to `int' in declaration of
`DECLARE_TASK_QUEUE'
drivers/char/isicom.c:83: warning: parameter names (without types) in function
declaration
drivers/char/isicom.c:83: warning: data definition has no type or storage class
drivers/char/isicom.c: In function `ISILoad_ioctl':
drivers/char/isicom.c:158: warning: comparison of distinct pointer types lacks a
cast
drivers/char/isicom.c:163: warning: comparison of distinct pointer types lacks a
cast
drivers/char/isicom.c: In function `schedule_bh':
drivers/char/isicom.c:359: warning: implicit declaration of function `queue_task'
drivers/char/isicom.c:359: `tq_isicom' undeclared (first use in this function)
drivers/char/isicom.c:359: (Each undeclared identifier is reported only once
drivers/char/isicom.c:359: for each function it appears in.)
drivers/char/isicom.c:360: warning: implicit declaration of function `mark_bh'
drivers/char/isicom.c:360: `ISICOM_BH' undeclared (first use in this function)
drivers/char/isicom.c: In function `do_isicom_bh':
drivers/char/isicom.c:488: warning: implicit declaration of function
`run_task_queue'
drivers/char/isicom.c:488: `tq_isicom' undeclared (first use in this function)
drivers/char/isicom.c: In function `isicom_interrupt':
drivers/char/isicom.c:587: warning: implicit declaration of function `schedule_task'
drivers/char/isicom.c:653: structure has no member named `tqueue'
drivers/char/isicom.c:653: `tq_timer' undeclared (first use in this function)
drivers/char/isicom.c:691: structure has no member named `tqueue'
drivers/char/isicom.c: In function `isicom_open':
drivers/char/isicom.c:975: warning: unused variable `flags'
drivers/char/isicom.c: In function `isicom_init':
drivers/char/isicom.c:1810: warning: implicit declaration of function `init_bh'
drivers/char/isicom.c:1810: `ISICOM_BH' undeclared (first use in this function)
drivers/char/isicom.c:1824: structure has no member named `routine'
drivers/char/isicom.c:1826: structure has no member named `routine'
drivers/char/isicom.c: In function `cleanup_module':
drivers/char/isicom.c:1959: warning: implicit declaration of function `remove_bh'
drivers/char/isicom.c:1959: `ISICOM_BH' undeclared (first use in this function)
make[2]: *** [drivers/char/isicom.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2
Comment 4 Thomas Wolfe 2003-08-07 00:28:38 UTC 
still in 2.6.0-test2

drivers/char/isicom.c:83: warning: type defaults to `int' in declaration of
`DECLARE_TASK_QUEUE'
drivers/char/isicom.c:83: warning: parameter names (without types) in function
declaration
drivers/char/isicom.c:83: warning: data definition has no type or storage class
drivers/char/isicom.c: In function `ISILoad_ioctl':
drivers/char/isicom.c:158: warning: comparison of distinct pointer types lacks a
cast
drivers/char/isicom.c:163: warning: comparison of distinct pointer types lacks a
cast
drivers/char/isicom.c: In function `schedule_bh':
drivers/char/isicom.c:359: warning: implicit declaration of function `queue_task'
drivers/char/isicom.c:359: `tq_isicom' undeclared (first use in this function)
drivers/char/isicom.c:359: (Each undeclared identifier is reported only once
drivers/char/isicom.c:359: for each function it appears in.)
drivers/char/isicom.c:360: warning: implicit declaration of function `mark_bh'
drivers/char/isicom.c:360: `ISICOM_BH' undeclared (first use in this function)
drivers/char/isicom.c: In function `do_isicom_bh':
drivers/char/isicom.c:488: warning: implicit declaration of function
`run_task_queue'
drivers/char/isicom.c:488: `tq_isicom' undeclared (first use in this function)
drivers/char/isicom.c: In function `isicom_interrupt':
drivers/char/isicom.c:587: warning: implicit declaration of function `schedule_task'
drivers/char/isicom.c:653: structure has no member named `tqueue'
drivers/char/isicom.c:653: `tq_timer' undeclared (first use in this function)
drivers/char/isicom.c:691: structure has no member named `tqueue'
drivers/char/isicom.c: In function `isicom_open':
drivers/char/isicom.c:975: warning: unused variable `flags'
drivers/char/isicom.c: In function `isicom_init':
drivers/char/isicom.c:1810: warning: implicit declaration of function `init_bh'
drivers/char/isicom.c:1810: `ISICOM_BH' undeclared (first use in this function)
drivers/char/isicom.c:1824: structure has no member named `routine'
drivers/char/isicom.c:1826: structure has no member named `routine'
drivers/char/isicom.c: In function `cleanup_module':
drivers/char/isicom.c:1959: warning: implicit declaration of function `remove_bh'
drivers/char/isicom.c:1959: `ISICOM_BH' undeclared (first use in this function)
make[2]: *** [drivers/char/isicom.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2
Comment 5 Zurd 2003-08-07 04:36:57 UTC 
Indeed, it is still not working on 2.6.0-test2

I have Linux 2.4.21-0.13mdk i686

Steps to reproduce : Character Devices / Multi-Tech multiport card support
Comment 6 Adrian Bunk 2004-07-10 17:09:23 UTC 
This bug is already fixed in recent 2.6 kernels.
Note You need to log in before you can comment on or make changes to this bug.