Bug 153 - compile failure on drivers/char/riscom8.c
Summary: compile failure on drivers/char/riscom8.c
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Serial (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Michael Kory Woods
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-10 05:49 UTC by John Kim
Modified: 2003-08-21 18:57 UTC (History)
0 users

See Also:
Kernel Version:
Subsystem:
Regression: ---
Bisected commit-id:


Attachments
okay download it and change the name from riscom8.cgi to riscom8.c (45.94 KB, application/octet-stream)
2003-08-07 02:10 UTC, Michael Kory Woods
Details

Description John Kim 2002-12-10 05:49:46 UTC
Exact Kernel version:  2.5.51
Distribution:  Gentoo 1.4rc1
Hardware Environment:  Abit-KG7-RAID, 512MB, Geforce3
Software Environment:  gcc 3.2 (3.2-r4)
Problem Description:

  gcc -Wp,-MD,drivers/char/.riscom8.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -f
no-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686
-Iarch/i386/mach-generic -nostdi
nc -iwithprefix include    -DKBUILD_BASENAME=riscom8 -DKBUILD_MODNAME=riscom8  
-c -o drivers/char/riscom8.o d
rivers/char/riscom8.c
In file included from drivers/char/riscom8.c:51:
drivers/char/riscom8.h:88: field `tqueue' has incomplete type
drivers/char/riscom8.h:89: field `tqueue_hangup' has incomplete type
drivers/char/riscom8.c:84: warning: type defaults to `int' in declaration of
`DECLARE_TASK_QUEUE'
drivers/char/riscom8.c:84: warning: parameter names (without types) in function
declaration
drivers/char/riscom8.c: In function `rc_init_CD180':
drivers/char/riscom8.c:247: warning: implicit declaration of function `save_flags'
drivers/char/riscom8.c:247: warning: implicit declaration of function `cli'
drivers/char/riscom8.c:251: warning: implicit declaration of function `sti'
drivers/char/riscom8.c:264: warning: implicit declaration of function
`restore_flags'
drivers/char/riscom8.c: In function `rc_mark_event':
drivers/char/riscom8.c:351: warning: implicit declaration of function `queue_task'
drivers/char/riscom8.c:351: `tq_riscom' undeclared (first use in this function)
drivers/char/riscom8.c:351: (Each undeclared identifier is reported only once
drivers/char/riscom8.c:351: for each function it appears in.)
drivers/char/riscom8.c:352: warning: implicit declaration of function `mark_bh'
drivers/char/riscom8.c:352: `RISCOM8_BH' undeclared (first use in this function)
drivers/char/riscom8.c: In function `rc_receive_exc':
drivers/char/riscom8.c:435: structure has no member named `tqueue'
drivers/char/riscom8.c:435: `tq_timer' undeclared (first use in this function)
drivers/char/riscom8.c: In function `rc_receive':
drivers/char/riscom8.c:466: structure has no member named `tqueue'
drivers/char/riscom8.c:466: `tq_timer' undeclared (first use in this function)
drivers/char/riscom8.c: In function `rc_check_modem':
drivers/char/riscom8.c:556: warning: implicit declaration of function
`schedule_task'
drivers/char/riscom8.c: In function `do_riscom_bh':
drivers/char/riscom8.c:1725: warning: implicit declaration of function
`run_task_queue'
drivers/char/riscom8.c:1725: `tq_riscom' undeclared (first use in this function)
drivers/char/riscom8.c: In function `rc_init_drivers':
drivers/char/riscom8.c:1754: warning: implicit declaration of function `init_bh'
drivers/char/riscom8.c:1754: `RISCOM8_BH' undeclared (first use in this function)
drivers/char/riscom8.c: In function `rc_release_drivers':
drivers/char/riscom8.c:1833: warning: implicit declaration of function `remove_bh'
drivers/char/riscom8.c:1833: `RISCOM8_BH' undeclared (first use in this function)
drivers/char/riscom8.c: At top level:
drivers/char/riscom8.c:84: warning: `DECLARE_TASK_QUEUE' declared `static' but
never defined
make[2]: *** [drivers/char/riscom8.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2


Steps to reproduce:

Character devices  /  SDL RISCom/8 card support
CONFIG_RISCOM8=y
Comment 1 Steven Barnhart 2002-12-28 07:04:43 UTC
This bug still is not fixed in 2.5.53 as a side note...
Comment 2 Jayce Dowell 2003-01-17 16:40:26 UTC
Nor in 2.5.59 if anyone is wondering...
Comment 3 Thomas Molina 2003-02-21 12:04:28 UTC
Compile still fails in 2.5.62
Comment 4 cwiz100 2003-04-06 00:07:14 UTC
still there in 2.5.66...
Comment 5 HJH 2003-05-24 05:39:11 UTC
still not compiling in 2.5.69
Comment 6 Dan Carpenter 2003-07-02 00:26:07 UTC
compiling in 2.5.73

510~/progs/kernel/devel/linux-2.5.73.$ make drivers/char/riscom8.o
make[1]: `drivers/char/riscom8.o' is up to date.
511~/progs/kernel/devel/linux-2.5.73.$ 


Comment 7 HJH 2003-07-08 09:17:05 UTC
Still not compiling in 2.5.74.
The module outputs the following:

  CC [M]  drivers/char/riscom8.o
In file included from drivers/char/riscom8.c:51:
drivers/char/riscom8.h:84: field `tqueue' has incomplete type
drivers/char/riscom8.h:85: field `tqueue_hangup' has incomplete type
drivers/char/riscom8.c:84: warning: type defaults to `int' in declaration of
`DECLARE_TASK_QUEUE'
drivers/char/riscom8.c:84: warning: parameter names (without types) in function
declaration
drivers/char/riscom8.c:135: confused by earlier errors, bailing out
make[2]: *** [drivers/char/riscom8.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

Comment 8 Zurd 2003-07-15 18:25:20 UTC
Still not fixed in 2.6.0-test1
But as said in "make menuconfig" or "make config" just select No for :
Character Devices / SDL RISCom/8 card support
And it'll work.
Comment 9 Thomas Wolfe 2003-08-07 00:31:26 UTC
still in 2.6.0-test2

In file included from drivers/char/riscom8.c:51:
drivers/char/riscom8.h:84: field `tqueue' has incomplete type
drivers/char/riscom8.h:85: field `tqueue_hangup' has incomplete type
drivers/char/riscom8.c:84: warning: type defaults to `int' in declaration of
`DECLARE_TASK_QUEUE'
drivers/char/riscom8.c:84: warning: parameter names (without types) in function
declaration
drivers/char/riscom8.c:135: confused by earlier errors, bailing out
make[2]: *** [drivers/char/riscom8.o] Error 1
make[1]: *** [drivers/char] Error 2
make: *** [drivers] Error 2

and yes No for :
Character Devices / SDL RISCom/8 card support
works
Comment 10 Michael Kory Woods 2003-08-07 02:10:41 UTC
Created attachment 621 [details]
okay download it and change the name from riscom8.cgi to riscom8.c

good luck
Comment 11 Michael Kory Woods 2003-08-07 02:25:32 UTC
Comment on attachment 621 [details]
okay download it and change the name from riscom8.cgi to riscom8.c

okay download it and change the name from riscom8.cgi to riscom8.c
Comment 12 Michael Kory Woods 2003-08-07 02:44:50 UTC
Comment on attachment 621 [details]
okay download it and change the name from riscom8.cgi to riscom8.c

doesnt work, sorry back to the drawing boards
Comment 13 John Kim 2003-08-21 18:57:22 UTC
Appears to be fixed in 2.6.0-test3-bk9.  Since I don't have the hardware I can't
confirm whether it works.

Note You need to log in before you can comment on or make changes to this bug.