Hello kernel developers. I found a bug report from a user in launchpad. I just copy it here. It includes patch. Here is the text: **** remote control for my tv card doesnt work I have Askey CPH03x TV Capturer. When I load bttv module with "card=59" option which is proper for this tv card, I can watch tv with sound but my remote control doesnt work. There is no ir event in /proc/bus/input/device . When bttv module is loaded with "card=137" option remote control works very well. $ cat /proc/bus/input/devices ....... ........ : Bus=0001 Vendor=109e Product=0350 Version=0001 N: Name="bttv IR (card=137)" P: Phys=pci-0000:00:0d.0/ir0 S: Sysfs=/devices/pci0000:00/0000:00:0d.0/input/input144 U: Uniq= H: Handlers=kbd event6 B: EV=100003 B: KEY=2c0814 100004 0 0 0 4 2008000 2090 2001 1e0000 4400 0 ffc Unfortunately there is no sound. ****end https://bugs.launchpad.net/ubuntu/+bug/239733
Created attachment 18750 [details] adds remote support to the bttv card Here is a patch for 2.6.27
thanks. but please, could you also post that on appropriate mailinglist or lkml, cc subsystem maintainer? bugzilla is not the best place for posting patches.
pablo, did you send your patch to linux-kernel@vger.kernel.org and/or linux-media@vger.kernel.org, cc mchehab@infradead.org ? it`s nice that you put it here, but it`s the wrong place. kernel developers mostly don`t care about patches being posted here. unfortunately, it`s (at least in the beginning) up to the patch sender to make sure that the patch being merged - you need at least follow the rules of submitting patches. also mind this readme: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches
Hello Roland. Thanks for your interest but I didn't send it to any official list. I started to read documentation about sending patches to the kernel but finally I gave up. I would thank you if you send it instead, since you look more familiarized with the process. Can you do it? Thanks in advance.
Hello Pablo, why did you give up ? did the submitting patches document discourage you ? it`s not so difficult to send patches upstream. just have a look into the mailing list archives how other people submit patches, those mails are typically being marked with [PATCH] in the subject field. it`s difficult to send a patch when someone (=me) can`t test it and cannot confirm that it works. so i need to trust you that it really works, and if it doesn`t i will get asked for it and i`m becoming an unecessary middleman. i`m not really that much familiarized with the process and, it`s not necessary that the patch is submitted in an absolute perfect way. what`s most important is that it is tested, that it applies to the latest linux kernel and that it`s being sent to a public list to go trough public review. maybe the subsystem maintainer picks it up and cleans it up, if necessary. but this one looks trivial... may you tell the reason why you don`t like to do that yourself ? you aren`t too shy for doing that, are you ? ;) please give it a try, i`m sure if you did that successfully once, sending your next patch is piece of cake....
The thing is that it's neither my patch and I don't own the hardware necessary to test it, but as you say it seems trivial. I gave up because I had not clear where to send the patch (which mailing list), and I lost the interest reading the documentation to send a patch that is not mine even. I think it is the reason. So you are saying that it's ok to send the patch to kernel@vger.kernel.org and/or linux-media@vger.kernel.org, and add mchehab@infradead.org to CC, right? I can do it and I can follow it until it's applied, I only didn't want to pollute the lists.
>The thing is that it's neither my patch and I don't own the hardware necessary >to test it ok, see how bad it was that the original patch creator did not care ? he needs to patch his own kernel with every new kernel release and don`t care for owners of the same device... i`d try linux-media@vger.kernel.org and mchehab@... first. leave out lkml. >I only didn't want to pollute the lists. you don`t. you contribute to linux! there are even more trivial patches being sent (whitespace fixes for example)
Okay, it's already sent. http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/9160 Thank you for your help Roland =)
commit ed44f66e4039dfc8fb7905078d546c83adf76811 "V4L/DVB (12585): Add remote support to cph03x bttv card"