Bug 11604 - Docked Thinkpad T60p does not wake from "suspend to RAM" if docking station has a SATA drive.
Summary: Docked Thinkpad T60p does not wake from "suspend to RAM" if docking station h...
Status: CLOSED PATCH_ALREADY_AVAILABLE
Alias: None
Product: ACPI
Classification: Unclassified
Component: Power-Sleep-Wake (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Shaohua
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-20 14:45 UTC by Chris Rankin
Modified: 2009-04-01 05:26 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.25.17, 2.6.26.5
Subsystem:
Regression: No
Bisected commit-id:


Attachments
Output from T60p dmidecode (15.67 KB, text/plain)
2008-09-20 14:50 UTC, Chris Rankin
Details
Output from T60p acpidump (264.91 KB, text/plain)
2008-09-20 14:50 UTC, Chris Rankin
Details
dmesg output of 2.6.26.5 without fglrx (30.56 KB, text/plain)
2008-09-21 07:04 UTC, Chris Rankin
Details
Xorg output of failed resume with radeonhd driver (67.65 KB, text/plain)
2008-09-21 07:05 UTC, Chris Rankin
Details
dmesg output of 2.6.26.5 with fglrx, resuming OK (47.63 KB, text/plain)
2008-09-21 07:11 UTC, Chris Rankin
Details
dmesg output of 2.6.26.5 + 11 ACPI dock patches (31.54 KB, text/plain)
2008-09-22 09:55 UTC, Chris Rankin
Details
dmesg output of 2.6.26.5 + 11 ACPI dock patches, resuming OK (39.43 KB, text/plain)
2008-09-22 09:59 UTC, Chris Rankin
Details

Description Chris Rankin 2008-09-20 14:45:31 UTC
Latest working kernel version: Never known to work.
Earliest failing kernel version: 2.6.25.x
Distribution: Fedora 9
Hardware Environment: Thinkpad T60p, advanced docking station with SATA drive.
Software Environment:

Problem Description: Thinkpad does not resume from "Suspend to RAM" when docked to a docking station that contains a SATA drive.

Steps to reproduce:
Put SATA drive in the docking station's drive bay, and dock T60p.
Suspend to RAM, and close lid. The "crescent moon" light comes on and the T60p beeps, to indicate that it has suspended successfully.
Reopen lid - the "crescent moon" light stays on and the T60p does not resume.

Removing the SATA drive allows the docked T60p to suspend and resume normally.
This bug can be reproduced without the fglrx module loaded, and using the radeonhd DDX Xorg driver.
Comment 1 Chris Rankin 2008-09-20 14:46:39 UTC
Oops - it's Fedora 8, not Fedora 9.
Comment 2 Chris Rankin 2008-09-20 14:50:11 UTC
Created attachment 17918 [details]
Output from T60p dmidecode
Comment 3 Chris Rankin 2008-09-20 14:50:58 UTC
Created attachment 17919 [details]
Output from T60p acpidump
Comment 4 Chris Rankin 2008-09-21 07:02:42 UTC
I've tried upgrading to the 2.6.26.5 kernel now that the Catalyst 8.9 driver has been released, and the problem still exists.
Comment 5 Chris Rankin 2008-09-21 07:04:18 UTC
Created attachment 17922 [details]
dmesg output of 2.6.26.5 without fglrx

I think the most interesting part of this is:

ACPI: \_SB_.PCI0.IDE0.PRIM.MSTR: found ejectable bay
ACPI: \_SB_.PCI0.IDE0.PRIM.MSTR: Adding notify handler
ACPI: Error installing bay notify handler
Comment 6 Chris Rankin 2008-09-21 07:05:28 UTC
Created attachment 17923 [details]
Xorg output of failed resume with radeonhd driver

I don't know if this is useful in any way.
Comment 7 Chris Rankin 2008-09-21 07:09:54 UTC
Ironically, the laptop *has* successfully resumed *once* with the SATA drive in the docking bay - using the 2.6.26.5 kernel and the fglrx driver! However, this has not proved to be repeatable.

The laptop still resumes reliably if the SATA drive is unplugged from the docking bay.
Comment 8 Chris Rankin 2008-09-21 07:11:19 UTC
Created attachment 17924 [details]
dmesg output of 2.6.26.5 with fglrx, resuming OK

OK, so this is from a tainted kernel. But this tainted kernel is WORKING (without the drive in the bay, of course).
Comment 9 Zhang Rui 2008-09-21 19:29:54 UTC
Shaohua has a patch set which fixed a lot of dock issue.
please give them a try. :)
http://marc.info/?l=linux-acpi&m=121988834907742&w=2

note that there are 11 patches in all.
Comment 10 Shaohua 2008-09-21 22:55:45 UTC
what's the result if put sata in dock at boot time (that is not doing runtime dock/undock)?
Comment 11 Chris Rankin 2008-09-22 01:57:58 UTC
(In reply to comment #10)
> what's the result if put sata in dock at boot time (that is not doing runtime
> dock/undock)?

Actually, I have always added and removed the SATA drive from the bay "cold". I'm not sure that it's safe to unplug "hot", not least because of the need to unmount it first.
Comment 12 Chris Rankin 2008-09-22 04:49:20 UTC
To clarify, I am not docking or undocking my laptop here either. The laptop is connected (locked!) to its docking station the whole time, and the SATA drive either is or isn't in the docking station's drive bay when I turn the power on.
Comment 13 Chris Rankin 2008-09-22 05:47:49 UTC
(In reply to comment #9)
> Shaohua has a patch set which fixed a lot of dock issue.
> please give them a try. :)
> http://marc.info/?l=linux-acpi&m=121988834907742&w=2
> 
> note that there are 11 patches in all.

I have needed to add the following line to drivers/acpi/osl.c in order to compile:

EXPORT_SYMBOL(acpi_os_hotplug_execute);
Comment 14 Chris Rankin 2008-09-22 09:55:19 UTC
Created attachment 17952 [details]
dmesg output of 2.6.26.5 + 11 ACPI dock patches

The dmesg output now shows the kernel finding 3 dock/bay devices, and there's no indication that a handler has not been installed. However, it still fails if the docking station has a SATA drive in.
Comment 15 Chris Rankin 2008-09-22 09:59:11 UTC
Created attachment 17953 [details]
dmesg output of 2.6.26.5 + 11 ACPI dock patches, resuming OK

I powered down, removed the SATA drive from the docking bay, and then powered up again. Here is the resulting dmesg log from a successful resume with the patched kernel.

I should point out that when the laptop failed to resume, Fedora 8 wrote nothing relating to trying to resuming into the pm-suspend.log file. Nor did the laptop beep, the crescent moon LED stayed lit, and I ended up having to power-cycle the laptop.
Comment 16 Zhang Rui 2008-10-30 00:47:27 UTC
re-assign to Shaohua.
Comment 17 Zhang Rui 2009-03-24 18:32:38 UTC
hi, Chris,

does the problem still exist in 2.6.29?
Comment 18 Chris Rankin 2009-03-30 21:00:26 UTC
(In reply to comment #17)
> does the problem still exist in 2.6.29?

I haven't tried 2.6.29, but the bug doesn't appear to be present in 2.6.28.9, for either suspend to RAM or suspend to disk.
Comment 19 Shaohua 2009-03-31 00:42:04 UTC
>but the bug doesn't appear to be present in 2.6.28.9
good. close it.

Note You need to log in before you can comment on or make changes to this bug.