Bug 10975 - pcmcia: CIS filename is too long [GLOBETROTTER.cis]
Summary: pcmcia: CIS filename is too long [GLOBETROTTER.cis]
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: PCMCIA (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Dominik Brodowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-24 02:41 UTC by Omair Eshkenazi
Modified: 2010-10-05 13:53 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.25.4
Subsystem:
Regression: No
Bisected commit-id:


Attachments
pcmcia: allow for longer CIS firmware filenames (1.17 KB, patch)
2008-06-24 06:48 UTC, Dominik Brodowski
Details | Diff

Description Omair Eshkenazi 2008-06-24 02:41:02 UTC
Problem Description: with a Dynamode Data/Fax Modem 16-bit PCMCIA card, dmesg gives:
pcmcia: CIS filename is too long [GLOBETROTTER.cis] 

(was reported here: http://puppylinux.com/blog/?viewDetailed=00160 and seems to be pretty old (my guess is it has always been this way...))

I assume it comes from line 922 of drivers/serial/serial_cs.c :
PCMCIA_DEVICE_CIS_MANF_CARD(0x0013, 0x0000, "GLOBETROTTER.cis"),

where "GLOBETROTTER.cis" is 16 chars long...

PCMCIA_DEVICE_CIS_MANF_CARD is defined at the top of include/pcmcia/device_id.h, where card_id is used, defined in include/pcmcia/ds.h as u16 (I hope I got this right... I don't really know what I'm talking about.).
Comment 1 Dominik Brodowski 2008-06-24 06:48:10 UTC
Created attachment 16597 [details]
pcmcia: allow for longer CIS firmware filenames

Could you try this bugfix, please? Of course, you need the proper file (GLOBETROTTER:cis) in /lib/firmware/ for it to work :)
Comment 2 Omair Eshkenazi 2008-06-29 02:42:52 UTC
This seems to actually make things worse...
See http://puppylinux.com/blog/?viewDetailed=00177
and http://puppylinux.com/blog/?viewDetailed=00178
Comment 3 Wolfram Sang 2009-07-30 10:29:22 UTC
Commit ed62acec209fa7e104b9d7871c1e5307fab83bf0 should have fixed that meanwhile. Can you confirm?
Comment 4 Dominik Brodowski 2009-10-17 12:13:42 UTC
I agree with Wolfram, and will close this bug
Comment 5 Wolfram Sang 2010-09-22 22:07:45 UTC
Can be really closed now :)

Note You need to log in before you can comment on or make changes to this bug.