Bug 10611 - Incorrect RFC section reference in comment
Summary: Incorrect RFC section reference in comment
Status: RESOLVED CODE_FIX
Alias: None
Product: Networking
Classification: Unclassified
Component: IPV4 (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Stephen Hemminger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-05-06 23:25 UTC by J.H.M. Dassen (Ray)
Modified: 2008-08-01 16:42 UTC (History)
0 users

See Also:
Kernel Version: master branch
Subsystem:
Regression: ---
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description J.H.M. Dassen (Ray) 2008-05-06 23:25:13 UTC 
Problem Description:

RFC 1122 does not have a section 3.1.2.2. The requirement to silently
discard packets with a bad checksum is in section 3.2.1.2 instead.

Proposed patch:

diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
index 212734c..5bdb8f4 100644
--- a/net/ipv4/ip_input.c
+++ b/net/ipv4/ip_input.c
@@ -394,7 +394,7 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt,
 	iph = skb->nh.iph;
 
 	/*
-	 *	RFC1122: 3.1.2.2 MUST silently discard any IP frame that fails the checksum.
+	 *	RFC1122: 3.2.1.2 MUST silently discard any IP frame that fails the checksum.
 	 *
 	 *	Is the datagram acceptable?
 	 *
Comment 1 Anonymous Emailer 2008-05-06 23:34:07 UTC 
Reply-To: akpm@linux-foundation.org

(switched to email.  Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Tue,  6 May 2008 23:25:14 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=10611
> 
>            Summary: Incorrect RFC section reference in comment
>            Product: Networking
>            Version: 2.5
>      KernelVersion: master branch
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: IPV4
>         AssignedTo: shemminger@linux-foundation.org
>         ReportedBy: jdassen@debian.org
> 
> 
> Problem Description:
> 
> RFC 1122 does not have a section 3.1.2.2. The requirement to silently
> discard packets with a bad checksum is in section 3.2.1.2 instead.
> 
> Proposed patch:
> 
> diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
> index 212734c..5bdb8f4 100644
> --- a/net/ipv4/ip_input.c
> +++ b/net/ipv4/ip_input.c
> @@ -394,7 +394,7 @@ int ip_rcv(struct sk_buff *skb, struct net_device *dev,
> struct packet_type *pt,
>         iph = skb->nh.iph;
> 
>         /*
> -        *      RFC1122: 3.1.2.2 MUST silently discard any IP frame that
> fails
> the checksum.
> +        *      RFC1122: 3.2.1.2 MUST silently discard any IP frame that
> fails
> the checksum.
>          *
>          *      Is the datagram acceptable?
>          *
> 
> 

Thanks, but we much prefer that patches be handled via email.  Can you
please resend the patch as a reply-to-all to this email, along with a
signed-off-by: as per Documentation/SubmittingPatches?
Note You need to log in before you can comment on or make changes to this bug.