Bug 10547 - Reboot fails on newer Dell OptiPlex 745
Summary: Reboot fails on newer Dell OptiPlex 745
Status: CLOSED CODE_FIX
Alias: None
Product: Platform Specific/Hardware
Classification: Unclassified
Component: i386 (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: platform_i386
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-24 07:31 UTC by Ben
Modified: 2008-05-05 07:40 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.24.5
Subsystem:
Regression: ---
Bisected commit-id:

Attachments
Remove match on DMI_BOARD_NAME (416 bytes, patch)
2008-05-03 02:45 UTC, Ben 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Description Ben 2008-04-24 07:31:43 UTC 
Hardware Environment: Dell OptiPlex 745

Steps to reproduce: Newer Dell OptiPlex 745s hang before rebooting after 'sudo reboot'.

A patch for some versions of the OptiPlex was proposed here -- http://lkml.org/lkml/2007/6/5/59 -- and is included in 2.6.23 and later kernels, according to http://lxr.linux.no/linux+v2.6.23/arch/i386/kernel/reboot.c . However, the DMI_BOARD_NAME ("0WF810") is too restrictive. Newer OptiPlex machines have a DMI_BOARD_NAME of "0RF703".  I therefore suggest adding another clause to reboot.c, similar to the one in the original patch, but matching a DMI_BOARD_NAME of "0RF703".
Comment 1 Ben 2008-05-03 02:45:05 UTC 
Created attachment 16011 [details]
Remove match on DMI_BOARD_NAME

On further inspection, it seems that there are other DMI_BOARD_NAMEs for this same machine. They seem to change from time to time, which means that the current code is fragile. Moreover, using bios reboot should not break non-SFF OptiPlex 745s, and so a reasonable fix is to simply drop the match on DMI_BOARD_NAME.
Comment 2 Adrian Bunk 2008-05-05 07:40:27 UTC 
fixed by commit 163ea310b68bdde89b1ac633fbf8c0db290d3f86
Note You need to log in before you can comment on or make changes to this bug.