Bug 10440 - CONFIG_RT2500USB description confusing about target
Summary: CONFIG_RT2500USB description confusing about target
Status: CLOSED WILL_NOT_FIX
Alias: None
Product: Networking
Classification: Unclassified
Component: Wireless (show other bugs)
Hardware: All Linux
: P1 low
Assignee: networking_wireless@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-10 20:03 UTC by Filipus Klutiero
Modified: 2012-09-25 12:37 UTC (History)
3 users (show)

See Also:
Kernel Version: 2.6.24
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Filipus Klutiero 2008-04-10 20:03:37 UTC
The description of CONFIG_RT2500USB contains "This is an experimental driver for the Ralink rt2500 wireless chip."
RT2500 specifically refers to PCI/PCMCIA/mini-PCI devices, so non-USB. It's a bastard name, but the name for RT2500USB is really RT2500USB. Note that "rt" and "usb" should be capitalized.
Comment 1 Andrew Morton 2008-04-10 20:34:31 UTC
email us a patch ;)
Comment 2 Filipus Klutiero 2008-04-10 20:48:48 UTC
Well, the fix is as trivial as 1-2-3^WU-S-B, but I can send a patch based on 2.6.24 if you tell me where to send it.
Comment 3 John W. Linville 2008-04-11 04:26:43 UTC
Sure, send it to linux-wireless@vger.kernel.org.  Please be sure to observe the conventions described here:

   http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
Comment 4 Filipus Klutiero 2008-05-05 18:23:01 UTC
I sent a patch fixing that. It can be seen on http://thread.gmane.org/gmane.linux.kernel.wireless.general/13522/focus=13776
Comment 5 Filipus Klutiero 2008-10-16 12:33:50 UTC
This is not fixed in 2.6.27.
Comment 6 John W. Linville 2008-10-17 05:24:17 UTC
The patch is there:

commit 3a4d3af700b3d78904775d9a9efe0858b5e1e955
Author: Ivo van Doorn <ivdoorn@gmail.com>
Date:   Mon Apr 21 19:01:40 2008 +0200

    rt2x00: Clarify supported chipsets in Kconfig

    As reported by Filipus Klutiero <chealer@gmail.com>,
    the rt2x00 Kconfig entries should be updated with
    specific chipset notifications.

    This cleans up Kconfig by explicitly mentioning the
    supported chipsets for each drivers, and uses the
    same chipset family names as mentioned on the Ralink website.

    Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

Please be more specific if you think there is still a problem.
Comment 7 Filipus Klutiero 2008-10-17 11:24:01 UTC
The patch you refer to is based the patch I sent to cleanup Kconfig, but it does not address the initial problem at all, except that the chances of confusion are lower with the other fixes.

The problem described in the original description remains, as "rt2500" is still used to refer to RT2500USB. Applying the patch I sent will fix this.
Comment 8 John W. Linville 2008-10-17 11:35:34 UTC
Is there some reason you insist on captialization?
Comment 9 Filipus Klutiero 2008-10-21 13:39:17 UTC
This bug is not just about capitalization. The final patch I sent, after feedback from Ivo, fixes a lot more than this bug. This bug is about referring to RT2500USB as "rt2500".
Comment 10 John W. Linville 2008-10-21 14:11:18 UTC
Oh good grief...send a new patch!
Comment 11 Filipus Klutiero 2008-10-21 14:15:24 UTC
Why?
Comment 12 John W. Linville 2008-10-21 14:24:47 UTC
The thread at the link from comment 4 ends just after Ivo NACKed your old patch.  'grep rt2500 * | grep -v rt2500usb | grep -v rt2500pci' only shows a couple of lines from Kconfig which I do not feel are unclear.

Given that, I have no idea what is the change you want made.  So, it falls upon you to post a patch to the mailing list (linux-wireless@vger.kernel.org) for proper review by the interested parties.

Now, please stop abusing bugzilla by reopening this...if you have something to contribute, send it to the mailing list.
Comment 13 Filipus Klutiero 2008-10-21 15:02:35 UTC
No, the thread ends with my comment on Ivo's NACK, with the question that remains unanswered. Until it's answered, the NACK should be ignored.

Regarding the change I want made, please see the original description of this bug. Kconfig should not refer to RT2500USB as "rt2500". I already posted a patch fixing that to the mailing list you mentioned, at Andrew Morton's request. The patch was reviewed by Ivo van Doorm.

Regarding the supposed Bugzilla abuse, I will not reopen the bug report if you refrain from closing it until the bug is fixed. You can count on me to close the bug report when the bug is fixed.
Comment 14 John W. Linville 2008-10-21 16:22:18 UTC
Post a patch.
Comment 15 Filipus Klutiero 2008-10-21 16:34:24 UTC
Already done.
Comment 16 John W. Linville 2008-10-21 16:56:20 UTC
The patch you posted was NACKed, the supposed problem is indecipherable -- nothing is going to happen unless you post a new patch.
Comment 17 Ivo van Doorn 2008-10-22 10:14:32 UTC
As far as I am concerned this case is really closed.

1) The patch you send was NACK'ed by me in a mail which included all reasons why I NACK'ed that patch. And no we are not going to ignore a NACK just because you don't agree on why it was NACK'ed.

2) A alternative patch created by me, which included some parts of your patch. On that patch you indicated you had no objections except for a few typo corrections which were also incorporated into the final patch which was merged into the kernel.

If you still have major issues with the remaining code in Kconfig, then post a patch and I'll review it. But please (much) make it better then the "rt2500 (USB)" to "RT2500USB" rename which you are hammering on...
Comment 18 Filipus Klutiero 2012-05-19 15:49:17 UTC
Alan, could you clarify how you tried to "reproduce" this? This bug is in the phrasing of the description.
Comment 19 Alan 2012-06-09 16:34:05 UTC
Sorry I meant to close it as obsolete
Comment 20 Filipus Klutiero 2012-06-09 16:45:51 UTC
OK, but why is it obsolete?
Comment 21 Filipus Klutiero 2012-09-24 23:51:52 UTC
This is still present in 3.4.

Note You need to log in before you can comment on or make changes to this bug.