Bug 9006
| Summary: | incorrect method to turn off DPLL in intel framebuffer driver | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | William Pan (william.pan) |
| Component: | Console/Framebuffers | Assignee: | Antonino Daplas (adaplas) |
| Status: | RESOLVED CODE_FIX | ||
| Severity: | normal | CC: | bunk |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 2.6.18.1 | Subsystem: | |
| Regression: | --- | Bisected commit-id: | |
|
Description
William Pan
2007-09-11 00:40:22 UTC
Reply-To: akpm@linux-foundation.org On Tue, 11 Sep 2007 00:40:22 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9006 > > Summary: incorrect method to turn off DPLL in intel framebuffer > driver > Product: Platform Specific/Hardware > Version: 2.5 > KernelVersion: 2.6.18.1 > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: i386 > AssignedTo: platform_i386@kernel-bugs.osdl.org > ReportedBy: william.pan@kontron.cn > > > in file intelfbhw.c, function intelfbhw_program_mode, the steps to > turn off DPLL: > tmp = INREG(dpll_reg); > dpll_reg &= ~DPLL_VCO_ENABLE; > OUTREG(dpll_reg, tmp); > guess it should be: > tmp = INREG(dpll_reg); > tmp &= ~DPLL_VCO_ENABLE; > OUTREG(dpll_reg, tmp); > am I right? > ? I believe so. Have you tried the driver with the modified code? No. william.pan 2007-09-12 Submitted a patch for the -mm tree. Thanks for the report. |