Bug 8065
Summary: | bug in Cyclades serial board's get_serial_info( ) function? | ||
---|---|---|---|
Product: | Drivers | Reporter: | Shan (shanlu) |
Component: | Serial | Assignee: | Russell King (rmk) |
Status: | CLOSED CODE_FIX | ||
Severity: | normal | CC: | bunk |
Priority: | P2 | ||
Hardware: | i386 | ||
OS: | Linux | ||
Kernel Version: | Linux-2.6.20 | Subsystem: | |
Regression: | --- | Bisected commit-id: |
Description
Shan
2007-02-22 18:45:46 UTC
I merged a patch, thanks. I just find a similar problem in another device: drivers/usb/serial/ti_usb_3410_5052.c 1402 static int ti_get_serial_info(struct ti_port *tport, 1403 struct serial_struct __user *ret_arg) ... 1413 ret_serial.type = PORT_16550A; 1414 ret_serial.line = port->serial->minor; 1415 ret_serial.port = port->number - port->serial->minor; 1416 ret_serial.flags = tport->tp_flags; 1417 ret_serial.xmit_fifo_size = TI_WRITE_BUF_SIZE; 1418 ret_serial.baud_base = tport->tp_tdev->td_is_3410 ? 921600 : 460800; 1419 ret_serial.closing_wait = tport->tp_closing_wait; I guess closing_delay is similarly missed, isn't it? Also, should ret_serial.irq be set and returned in this function? Patch was merged into Linus' tree, and will therefore be in 2.6.21. |