Bug 6537

Summary:	#ifdef CONFIG_PM causes MPT to not compile
Product:	IO/Storage	Reporter:	Bill Crowell (bill)
Component:	Other	Assignee:	Alexey Dobriyan (adobriyan)
Status:	CLOSED CODE_FIX
Severity:	blocking
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6.17-rc4	Subsystem:
Regression:	---	Bisected commit-id:

Description Bill Crowell 2006-05-12 07:49:08 UTC

Most recent kernel where this bug did not occur: 2.6.17-rc3
Distribution: slack
Hardware Environment: i386
Software Environment: gcc 3.3
Problem Description: /drivers/message/fusion/mpt* using #ifdef CONFIG_PM are not
exporting the mpt_suspend mpt_resume. I do not know why we would want to
exercise power management on high-performance scsi controllers in the first
place. LSI controllers are server devices.

Steps to reproduce: compile the kernel. causes a kernel compilation failure.

Steps to fix:
comment out the #ifdef CONFIG_pm and corresponding #endif to disable this
compilation flag. recompile and the world is happy.

Comment 1 Alexey Dobriyan 2006-05-12 09:53:56 UTC

This patch fixes your anonymous compilation problems?

[PATCH] mptspi: fix compilation with CONFIG_PM=n

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

--- a/drivers/message/fusion/mptspi.c
+++ b/drivers/message/fusion/mptspi.c
@@ -831,6 +831,7 @@ mptspi_ioc_reset(MPT_ADAPTER *ioc, int r
 	return rc;
 }
 
+#ifdef CONFIG_PM
 /*
  * spi module resume handler
  */
@@ -846,6 +847,7 @@ mptspi_resume(struct pci_dev *pdev)
 
 	return rc;
 }
+#endif
 
 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/
 /*=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=*/

Comment 2 Alexey Dobriyan 2006-08-16 04:51:57 UTC

Fixed in mainline.