Bug 5423

Summary:	Memory leak till the Method exit for each execution of Break
Product:	ACPI	Reporter:	Valery A Podrezov (Valery.A.Podrezov)
Component:	ACPICA-Core	Assignee:	Valery A Podrezov (Valery.A.Podrezov)
Status:	CLOSED CODE_FIX
Severity:	normal	CC:	acpi-bugzilla
Priority:	P2
Hardware:	i386
OS:	Linux
Kernel Version:	2.6	Subsystem:
Regression:	---	Bisected commit-id:
Attachments:	ASL code to reproduce bug. Patch fixing both 5423 and 5424

Description Valery A Podrezov 2005-10-12 10:15:44 UTC

Most recent kernel where this bug did not occur:
Distribution:
Hardware Environment:
Software Environment:
Problem Description:

The "memory leak" bug.
The Linux kernel ACPI interpreter after completion the
AML Break operation doesn't release some memory allocations.
The issue has been revealed by PMEMCV, is not seen by OAS (see bug 5422).

Steps to reproduce:

Run interpreter with the .asl demo code attached below
to observe the slowing down of interpretation visually.

Comment 1 Valery A Podrezov 2005-10-12 10:17:29 UTC

Created attachment 6286 [details]
ASL code to reproduce bug.

The attached AML test being run on the Linux kernel ACPI interpreter
when it is compiled into a simulator allows to observe the problem.
Each time when the Break operator is executed new memory leaks are
produced.

To make the problem visual the demo runs this operation in a
long enough cycle (0xA000 repetitions). So that you even can
observe the slowing down of interpretation visually.


INTERNAL BUG NUMBER

   158

Comment 2 Valery A Podrezov 2005-12-05 02:52:24 UTC

Created attachment 6770 [details]
Patch fixing both 5423 and 5424

The patch essentially decreases the time of execution of programs like given by
demo.

A. Time of execution of demo program BEFORE update:

   CYGWIN_NT-5.1 1.5.18(0.132/4/2) 2005-07-02 20:30 i686 unknown unknown Cygwin


      4 minutes 14 seconds (+ noise of swapping)

   Linux 2.6.5-7.191-smp #1 SMP Tue Jun 28 14:58:56 UTC 2005 i686 i686 i386
GNU/Linux

      3 minutes 26 seconds (+ noise of swapping)

B. Time of execution of demo program AFTER update:

   CYGWIN_NT-5.1 1.5.18(0.132/4/2) 2005-07-02 20:30 i686 unknown unknown Cygwin


		16 seconds (NO noise of swapping)

   Linux 2.6.5-7.191-smp #1 SMP Tue Jun 28 14:58:56 UTC 2005 i686 i686 i386
GNU/Linux

		16 seconds (NO noise of swapping)


The update was tested by the ASLTS test suite runs
(all the test cases) on the following systems:

- CYGWIN_NT-5.1 1.5.18(0.132/4/2) 2005-07-02 20:30 i686 unknown unknown Cygwin
- Linux 2.6.5-7.191-smp #1 SMP Tue Jun 28 14:58:56 UTC 2005 i686 i686 i386
GNU/Linux

for the following (all) modes supported by the ASLTS test suite:

- 32-bit norm mode
- 64-bit norm mode
- 32-bit slack mode
- 32-bit slack mode

The tests were run (on the systems described above) before update,
then the tests were run on those systems after update. Then results
of two runs were compared. All is Ok (no new errors).

Comment 3 Robert Moore 2005-12-06 14:31:30 UTC

Integrated for next release of ACPICA

Comment 4 Robert Moore 2006-02-07 13:46:12 UTC

Released in ACPICA version 20051216

Comment 5 Len Brown 2007-01-15 08:52:48 UTC

ACPICA 20060127 shipped in Linux-2.6.16
closed.