Bug 219

Summary: compile failure in drivers/scsi/tmscsim.c
Product: SCSI Drivers Reporter: John Kim (john)
Component: OtherAssignee: Mike Anderson (andmike)
Status: CLOSED CODE_FIX    
Severity: normal    
Priority: P2    
Hardware: i386   
OS: Linux   
Kernel Version: Subsystem:
Regression: --- Bisected commit-id:
Attachments: Some little changes to the file scsiiom.c, used only by the tmscsim.c
Changes to the tmscsim.c file for compiling in 2.5.xx kernels

Description John Kim 2002-12-30 12:54:27 UTC
Exact Kernel version:  2.5.53
Distribution:  Gentoo 1.4rc1
Hardware Environment:  Abit KG7-RAID, AMD Athlon TBird 1.4, 512MB DDR, Geforce 3
Software Environment:  gcc 3.2.1, glibc 2.3.1, ld 2.13.90.0.16
Problem Description:

  gcc -Wp,-MD,drivers/scsi/.tmscsim.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=athlon -Iinclude/asm-i386/mach-numaq
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include   
-DKBUILD_BASENAME=tmscsim -DKBUILD_MODNAME=tmscsim   -c -o
drivers/scsi/tmscsim.o drivers/scsi/tmscsim.c
drivers/scsi/tmscsim.c: In function `DC390_waiting_timed_out':
drivers/scsi/tmscsim.c:1074: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:1078: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c: In function `dc390_BuildSRB':
drivers/scsi/tmscsim.c:1146: structure has no member named `address'
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c:9:2: #error Please convert me to
Documentation/DMA-mapping.txt
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c: In function `DC390_Interrupt':
drivers/scsi/scsiiom.c:267: `DC390_LOCK_IO' undeclared (first use in this function)
drivers/scsi/scsiiom.c:267: (Each undeclared identifier is reported only once
drivers/scsi/scsiiom.c:267: for each function it appears in.)
drivers/scsi/scsiiom.c:343: `DC390_UNLOCK_IO' undeclared (first use in this
function)
drivers/scsi/scsiiom.c:229: warning: unused variable `iflags'
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c: In function `dc390_DataOut_0':
drivers/scsi/scsiiom.c:384: structure has no member named `address'
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c: In function `dc390_DataIn_0':
drivers/scsi/scsiiom.c:448: structure has no member named `address'
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c: In function `dc390_restore_ptr':
drivers/scsi/scsiiom.c:747: structure has no member named `address'
drivers/scsi/scsiiom.c:761: structure has no member named `address'
drivers/scsi/scsiiom.c:764: structure has no member named `address'
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c: In function `dc390_DataIO_Comm':
drivers/scsi/scsiiom.c:898: structure has no member named `address'
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c: In function `dc390_SRBdone':
drivers/scsi/scsiiom.c:1373: structure has no member named `address'
drivers/scsi/scsiiom.c:1448: structure has no member named `address'
drivers/scsi/scsiiom.c:1523: structure has no member named `address'
In file included from drivers/scsi/tmscsim.c:1825:
drivers/scsi/scsiiom.c: In function `dc390_RequestSense':
drivers/scsi/scsiiom.c:1764: structure has no member named `address'
drivers/scsi/tmscsim.c: In function `dc390_inquiry':
drivers/scsi/tmscsim.c:2403: request for member `rq_status' in something not a
structure or union
drivers/scsi/tmscsim.c: In function `dc390_sendstart':
drivers/scsi/tmscsim.c:2453: request for member `rq_status' in something not a
structure or union
drivers/scsi/tmscsim.c: In function `dc390_set_info':
drivers/scsi/tmscsim.c:2560: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2609: `p' undeclared (first use in this function)
drivers/scsi/tmscsim.c:2635: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2637: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2655: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2658: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2661: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2673: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2686: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2724: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2731: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2741: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2749: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2755: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2763: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2769: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2778: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2785: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2793: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2800: warning: passing arg 1 of `strsep' makes pointer
from integer without a cast
drivers/scsi/tmscsim.c:2809: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c:2817: request for member `pScsiHost' in something not a
structure or union
drivers/scsi/tmscsim.c: At top level:
drivers/scsi/tmscsim.c:3059: warning: initialization from incompatible pointer type
drivers/scsi/tmscsim.c:3059: warning: initialization from incompatible pointer type
drivers/scsi/tmscsim.c:277: warning: `tmscsim_pci_tbl' defined but not used
make[2]: *** [drivers/scsi/tmscsim.o] Error 1
make[1]: *** [drivers/scsi] Error 2
make: *** [drivers] Error 2


Steps to reproduce:

SCSI device support  --->
SCSI low-level drivers  --->
<*> Tekram DC390(T) and Am53/79C974 SCSI support

CONFIG_SCSI_DC390T=y
Comment 1 John Kim 2003-02-14 20:32:22 UTC
Problem exists in 2.5.61.
Comment 2 Albert Gonzalez 2003-02-18 06:40:51 UTC
Created attachment 164 [details]
Some little changes to the file scsiiom.c, used only by the tmscsim.c

Must apply this and the tmscsi.c.diff too to compile.
Comment 3 Albert Gonzalez 2003-02-18 06:42:43 UTC
Created attachment 165 [details]
Changes to the tmscsim.c file for compiling in 2.5.xx kernels

Changes to tmscsim.c to compile. The code isn't tested. May be faulty, but now
compiles with warnings.
apply too the scsiom.c.diff patch.
Comment 4 Robert Penz 2003-03-22 08:07:36 UTC
patch doesn't work for 2.5.65 
 
I had a look at the patches, there is no bh_next in PSCSICMD in 2.5.65!  
 
without the patch I get following error message. 
 
 
 gcc -Wp,-MD,drivers/scsi/.tmscsim.o.d -D__KERNEL__ -Iinclude -Wall 
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common 
-pipe -mpreferred-stack-boundary=2 -march=pentium4 
-Iinclude/asm-i386/mach-default -nostdinc -iwithprefix include    
-DKBUILD_BASENAME=tmscsim -DKBUILD_MODNAME=tmscsim -c -o 
drivers/scsi/tmscsim.o drivers/scsi/tmscsim.c 
drivers/scsi/tmscsim.c: In function `dc390_Query_append': 
drivers/scsi/tmscsim.c:872: structure has no member named `next' 
drivers/scsi/tmscsim.c:877: structure has no member named `next' 
drivers/scsi/tmscsim.c: In function `dc390_Query_get': 
drivers/scsi/tmscsim.c:889: structure has no member named `next' 
drivers/scsi/tmscsim.c:890: structure has no member named `next' 
drivers/scsi/tmscsim.c: In function `DC390_waiting_timed_out': 
drivers/scsi/tmscsim.c:1074: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:1078: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c: In function `dc390_BuildSRB': 
drivers/scsi/tmscsim.c:1146: structure has no member named `address' 
drivers/scsi/tmscsim.c: In function `DC390_abort': 
drivers/scsi/tmscsim.c:1564: structure has no member named `next' 
drivers/scsi/tmscsim.c:1565: structure has no member named `next' 
drivers/scsi/tmscsim.c:1573: structure has no member named `next' 
drivers/scsi/tmscsim.c:1575: structure has no member named `next' 
drivers/scsi/tmscsim.c:1575: structure has no member named `next' 
drivers/scsi/tmscsim.c:1576: structure has no member named `next' 
drivers/scsi/tmscsim.c:1584: structure has no member named `next' 
drivers/scsi/tmscsim.c:1627: structure has no member named `next' 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c:9:2: #error Please convert me to 
Documentation/DMA-mapping.txt 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c: In function `DC390_Interrupt': 
drivers/scsi/scsiiom.c:267: `DC390_LOCK_IO' undeclared (first use in this 
function) 
drivers/scsi/scsiiom.c:267: (Each undeclared identifier is reported only 
once 
drivers/scsi/scsiiom.c:267: for each function it appears in.) 
drivers/scsi/scsiiom.c:343: `DC390_UNLOCK_IO' undeclared (first use in 
this function) 
drivers/scsi/scsiiom.c:229: warning: unused variable `iflags' 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c: In function `dc390_DataOut_0': 
drivers/scsi/scsiiom.c:384: structure has no member named `address' 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c: In function `dc390_DataIn_0': 
drivers/scsi/scsiiom.c:448: structure has no member named `address' 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c: In function `dc390_restore_ptr': 
drivers/scsi/scsiiom.c:747: structure has no member named `address' 
drivers/scsi/scsiiom.c:761: structure has no member named `address' 
drivers/scsi/scsiiom.c:764: structure has no member named `address' 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c: In function `dc390_DataIO_Comm': 
drivers/scsi/scsiiom.c:898: structure has no member named `address' 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c: In function `dc390_SRBdone': 
drivers/scsi/scsiiom.c:1373: structure has no member named `address' 
drivers/scsi/scsiiom.c:1448: structure has no member named `address' 
drivers/scsi/scsiiom.c:1523: structure has no member named `address' 
In file included from drivers/scsi/tmscsim.c:1825: 
drivers/scsi/scsiiom.c: In function `dc390_RequestSense': 
drivers/scsi/scsiiom.c:1764: structure has no member named `address' 
drivers/scsi/tmscsim.c: In function `dc390_initAdapter': 
drivers/scsi/tmscsim.c:2092: warning: `__check_region' is deprecated 
(declared at include/linux/ioport.h:112) 
drivers/scsi/tmscsim.c:2102: warning: implicit declaration of function 
`request_irq' 
drivers/scsi/tmscsim.c: In function `dc390_inquiry': 
drivers/scsi/tmscsim.c:2404: request for member `rq_status' in something 
not a structure or union 
drivers/scsi/tmscsim.c: In function `dc390_sendstart': 
drivers/scsi/tmscsim.c:2455: request for member `rq_status' in something 
not a structure or union 
drivers/scsi/tmscsim.c: In function `dc390_set_info': 
drivers/scsi/tmscsim.c:2562: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2611: `p' undeclared (first use in this function) 
drivers/scsi/tmscsim.c:2637: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2639: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2657: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2660: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2663: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2675: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2688: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2726: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2733: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2745: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2753: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2759: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2767: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2773: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2782: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2789: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2797: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2804: warning: passing arg 1 of `strsep' makes 
pointer from integer without a cast 
drivers/scsi/tmscsim.c:2813: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c:2821: request for member `pScsiHost' in something 
not a structure or union 
drivers/scsi/tmscsim.c: In function `DC390_proc_info': 
drivers/scsi/tmscsim.c:2937: structure has no member named `next' 
drivers/scsi/tmscsim.c: At top level: 
drivers/scsi/tmscsim.c:3063: warning: initialization from incompatible 
pointer type 
drivers/scsi/tmscsim.c:3063: warning: initialization from incompatible 
pointer type 
drivers/scsi/tmscsim.c:277: warning: `tmscsim_pci_tbl' defined but not used 
make[2]: *** [drivers/scsi/tmscsim.o] Error 1 
make[1]: *** [drivers/scsi] Error 2 
make: *** [drivers] Error 2 
 
Comment 5 HJH 2003-07-08 12:28:42 UTC
the version that
Comment 6 HJH 2003-08-29 12:27:43 UTC
still does not compile in 2.6.0-test4
Comment 7 Adrian Bunk 2004-03-21 06:44:50 UTC
This issue was fixed some time ago.

Please close this bug.