Bug 1685
Summary: | To bus device, _CRS return the resources that it decodes | ||
---|---|---|---|
Product: | ACPI | Reporter: | Luming Yu (luming.yu) |
Component: | Config-Interrupts | Assignee: | Luming Yu (luming.yu) |
Status: | CLOSED PATCH_ALREADY_AVAILABLE | ||
Severity: | normal | CC: | acpi-bugzilla |
Priority: | P2 | ||
Hardware: | i386 | ||
OS: | Linux | ||
Kernel Version: | 2.6.0 IA64 | Subsystem: | |
Regression: | --- | Bisected commit-id: | |
Attachments: | a patch for fixing this issue |
Description
Luming Yu
2003-12-15 23:51:20 UTC
Created attachment 1678 [details]
a patch for fixing this issue
wrote:
> On Tue, Dec 16, 2003 at 05:37:35PM +0800, Yu, Luming wrote:
> > Could you let me see what are you patch doing.
>
> I haven't seen Bjorn's patch yet, but it'll be something like:
>
> --- arch/ia64/pci/pci.c 12 Aug 2003 19:10:49 -0000 1.3
> +++ arch/ia64/pci/pci.c 16 Dec 2003 12:13:53 -0000
> @@ -153,7 +153,7 @@ alloc_resource (char *name, struct resou
> res->end = end;
> res->flags = flags;
>
> - if (request_resource(root, res))
> + if (insert_resource(root, res))
> return -EBUSY;
>
> return 0;
Yup, that's exactly the patch.
And I agree with Matthew about preferring this over your patch.
Did you look at /proc/iomem with and without your patch? The
value of keeping the request_resource() (or insert_resource())
should be obvious.
Bjorn
|