Bug 14607
Summary: | LED not working in ath5k AR242x subsystem 1a32:0112 | ||
---|---|---|---|
Product: | Networking | Reporter: | Shahar Or (mightyiampresence) |
Component: | Wireless | Assignee: | networking_wireless (networking_wireless) |
Status: | CLOSED CODE_FIX | ||
Severity: | normal | CC: | linville, me |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.31 | Subsystem: | |
Regression: | No | Bisected commit-id: | |
Attachments: | lspci -vnn |
Description
Shahar Or
2009-11-15 17:58:00 UTC
I'm guessing we need some information on how the led is connected -- hopefully Bob can direct you on how to determine that? The values of led and polarity (usually 3,0) are needed. It would be nice if this information was available in ACPI somewhere but I am unaware of where to look. Atheros haven't told us how they determine the gpio programming for Windows. We can add a modparam, I guess. Since I'm not a developer I'm not familiar with all the terms you're using so if I can be of any assistance in debugging this please ask me directly and I will. Does it make sense to just ask them? I'm willing to do that. There's a bounty on this bug: http://www.fossfactory.org/project/p187 I have asked them before, without response. You can be of assistance -- you need to try the led and polarity values for your hardware (since I can't test it myself). So open up drivers/net/wireless/ath/ath5k/led.c, look for the part that says led_devices, then add something like: /* name of laptop (your contact email) */ { ATH_SDEVICE(PCI_VENDOR_ID_QMI, 0x0112), ATH_LED(3, 0) }, If that doesn't work, try ATH_LED(1, 0). Let me know what works. If you do get it working, do feel free to create a patch with your Signed-off-by and send it to John (see http://wireless.kernel.org/en/developers/Documentation/SubmittingPatches) -- then you can get credit for fixing it too :) Dear Bob, I did that using ATH_LED(3, 0) and now the WiFi LED seems to act as an activity indicator. Is that how it is supposed to act? I've only seen these LEDs work as on/off indicators. Blessings. The patch was committed. I don't know your bug tracking procedures so leaving it to you. Thank you, Bob. http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=6a213afd058436dbbd01098d7422c6a0073c39b5 And still, isn't there a way to get this working on all the devices? Information from Atheros, perhaps or something you said about ACPI? Can I help? |