Bug 14601
Summary: | Wrong handling of META_BG when getting number of blocks for group descriptors | ||
---|---|---|---|
Product: | File System | Reporter: | DamienDGU |
Component: | ext4 | Assignee: | fs_ext4 (fs_ext4) |
Status: | CLOSED OBSOLETE | ||
Severity: | normal | CC: | alan, jack, tytso |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | Subsystem: | ||
Regression: | No | Bisected commit-id: | |
Attachments: | ext3/balloc.c and ext4/balloc.c change to count number of descriptors blocks |
Description
DamienDGU
2009-11-14 11:15:15 UTC
Thanks for the patch. It looks good but please look at Documentation/SubmittingPatches how a patch for kernel should look like (most notably it misses a Signed-off-by, it should be in a unified format and with a changelog). Also please create one patch for ext3 and one patch for ext4 since I will merge the ext3 part and Ted Tso takes care of ext4. Thanks. Jan, I have a IMHO better set of patches which I plan to merge for ext4; it ends up simplifying the code, and makes it easier to read. I'll backport my ext4 fixes to ext3 and send them to you. It's on my todo list. OK, I'll wait for your backport then. Thanks. |