Bug 14217

Summary: Build Failure: wrong headers in rt2x00lib.h cause build failure for rt2x00dev.c
Product: Drivers Reporter: Ken Lewis (kennylewis)
Component: network-wirelessAssignee: drivers_network-wireless (drivers_network-wireless)
Status: CLOSED CODE_FIX    
Severity: normal CC: andy, linville
Priority: P1    
Hardware: All   
OS: Linux   
Kernel Version: Linus' git tree; linux-next since early September Subsystem:
Regression: No Bisected commit-id:
Attachments: Patch to resolve build error.

Description Ken Lewis 2009-09-23 20:58:15 UTC
Created attachment 23160 [details]
Patch to resolve build error.

Since linux-next-20090903 (possibly a few days earlier -- was on holiday), I've been getting build failures for rt2x00dev.c because of wrongly-formatted headers for rt2x00crypto_rx_insert_iv.

The attached patch resolves the issue for me and applied cleanly and built on tonight's Linus tree as well as linux-next trees from last week.  I sent patches to linux-next and linux-net but had no acknowledgement, and am preparing a re-send to include LKML too.  I'm horrified that a fixable bug with an existing patch has migrated to Linus' mainline for 2.6.32.
Comment 1 Andrew Price 2009-09-24 18:15:02 UTC
Hi Ken,

This was discussed on lkml in this thread:

http://thread.gmane.org/gmane.linux.kernel/891014

The submitted patch referenced in that thread was sent to linux-wireless here:

http://article.gmane.org/gmane.linux.kernel.wireless.general/39733

I expect John Linville and/or Dave Miller will send it to Linus as part of a batch soon.

Cheers,

Andrew
Comment 2 Andrew Price 2009-09-26 13:01:58 UTC
Fixed in mainline (fe2475633676b0a976400dfc53f8d7006f56543e)