Bug 13580
| Summary: | /var/log/message contains non-printable character | ||
|---|---|---|---|
| Product: | ACPI | Reporter: | Toralf Förster (toralf.foerster) |
| Component: | Other | Assignee: | acpi_other |
| Status: | CLOSED CODE_FIX | ||
| Severity: | normal | CC: | lenb, Robert.Moore, rui.zhang |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://bugs.gentoo.org/show_bug.cgi?id=274257 | ||
| Kernel Version: | 2.6.29.5 | Subsystem: | |
| Regression: | No | Bisected commit-id: | |
| Attachments: |
log line
dmesg /tmp/acpidump patch: support non-printable character in ACPI table header patch from Bob |
||
Please attach the full message log and the acpidump for the machine. Created attachment 22011 [details]
dmesg
attached is the dmesg output, I can't find acpidump within Gentoo's repository.
Created attachment 22012 [details]
/tmp/acpidump
Gentoo package name was pmtools ...
From the acpidump, your ACPI DMAR table has an unusual string in the header: DMAR @ 0x7c706000 0000: 44 4d 41 52 20 01 00 00 01 46 20 20 20 20 20 20 DMAR ....F 0010: 01 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 ................ 0020: 00 00 00 00 23 00 00 00 00 00 00 00 00 00 00 00 ....#........... The value starting at offset 0010 is the "OEM Table ID". It starts with 0x01, which is not a printable ascii character. The function that dumps the table headers should probably handle non-printable characters. IMO, this is clearly a BIOS bug to me. Bob, do you mean you want to workaround it in ACPICA core? Created attachment 22040 [details]
patch: support non-printable character in ACPI table header
Bob, do you mean a patch like this?
Toralf, can you please try this patch and see if it helps?
This comes up every once in a while. Enough so that I think we should just workaround it. I have a fix for it already. I take a copy of the header and stuff a '?' for every non-printable character. that's great. can you attach it here and close the bug report please? :) It is against the ACPICA core, so it has to wait until Linux integration. Created attachment 22136 [details]
patch from Bob
great. toralf, The patch should be shipped in the next ACPICA release and soon hit upsteam kernl. please re-open it if the patch doesn't work for you. this patch is in the queue for 2.6.32
cf02cd47d4747abf8ff0617e15fc05a00202e6d5
ACPICA: Dump table header - suppress output of non-printable characters
Function acpi_tb_print_table_header. Some ACPI tables contain
non-printable characters in one of the string fields of the the
header - Signature, OemId, OemTableId, or CompilerId. Invalid
characters are replaced by '?'. ACPICA BZ 788.
http://acpica.org/bugzilla/show_bug.cgi?id=788
patch above shipped in 2.6.32-rc2 closed. |
Created attachment 22007 [details] log line The attached file is a line which I have within my /var/log/messages of my ThinkPad T400. Unfortunateley that's why less won't show that file as text :-(