Bug 10736
Summary: | ip2main has issues | ||
---|---|---|---|
Product: | Drivers | Reporter: | Roland Kletzing (devzero) |
Component: | Serial | Assignee: | Alan (alan) |
Status: | CLOSED PATCH_ALREADY_AVAILABLE | ||
Severity: | normal | CC: | akpm, alan |
Priority: | P1 | ||
Hardware: | All | ||
OS: | Linux | ||
Kernel Version: | 2.6.26-rc2 | Subsystem: | |
Regression: | --- | Bisected commit-id: | |
Attachments: | mostly allmodconfig .config |
Description
Roland Kletzing
2008-05-17 13:24:45 UTC
Created attachment 16176 [details]
mostly allmodconfig .config
Could be that Alan broke it, could be that it was always broken. But I'll semi-randomly reassign this one to Jiri because he has a good eye for these things ;) I suppose there is a "Still loaded" message, right? Please, when you report bugs, report ALL relevant information! I mean, it is one line before the BUG or so. Blah, the init is a mess and crap. It was bad presumption. I see it. There are 2 ip2 modules. Main and base. Main init is noop, deinit frees all the stuff including tty. Base has no deinit, while its init calls another init from main which allocates tty and other stuff. So if someone includes only main, not the base and remove the main right after it, there is nobody who initialized that but main tries to deinit all the stuff, unsuccessfully. Looks like they want turning into one module to be honest. Jiri - I'll pick this up as I'm already carrying a pile of other ip2 changes >I suppose there is a "Still loaded" message, right?
i double checked, but - no - i donĀ“t see such message.
Test fix posted to lkml thanks! i found that this had been merged. additionally, i have just sent minor documentation fix to lkml. closing now. Subject: [PATCH] fix Kconfig after ip2/ip2main merge From: devzero@web.de To: linux-kernel@vger.kernel.org Cc: Alan Cox <alan@redhat.com>,Andrew Morton <akpm@linux-foundation.org>,Jiri Slaby <jirislaby@gmail.com> Date: 31.05.08 02:43:09 Uhr as commit 6089093e588ee3f6aed99d08b1cf5ea37c52cf97 is fixing ip2 crashes on load/unload and making ip2/ip2main one module (ip2), Kconfig shouldn`t mention non existing module. I seldom posting patches and only have webmailer here, so please indulge if there is something wrong with formatting or style. Signed-off-by: Roland.Kletzing <devzero@web.de> --- drivers/char/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) =================================================================== --- a/drivers/char/Kconfig.orig 2008-05-31 02:14:42.000000000 +0200 +++ b/drivers/char/Kconfig 2008-05-31 02:15:15.000000000 +0200 @@ -118,8 +118,8 @@ order to become a dial-in server. If you have a card like that, say Y here and read <file:Documentation/computone.txt>. - To compile this driver as modules, choose M here: the - modules will be called ip2 and ip2main. + To compile this driver as module, choose M here: the + module will be called ip2. config ROCKETPORT tristate "Comtrol RocketPort support" |